From c361da845a205ac35e724c0ca436744d483de7aa Mon Sep 17 00:00:00 2001
From: Romain Guy <romainguy@google.com>
Date: Mon, 25 Oct 2010 15:29:10 -0700
Subject: [PATCH] Don't initialize the hw renderer without a valid surface. Bug
 #3054952

Change-Id: I5b4074391dbd84b04a14f7d2fb1b9a4a2487e1e2
---
 core/java/android/view/ViewRoot.java | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/core/java/android/view/ViewRoot.java b/core/java/android/view/ViewRoot.java
index ea688adcb91e4..2e368b811a286 100644
--- a/core/java/android/view/ViewRoot.java
+++ b/core/java/android/view/ViewRoot.java
@@ -822,7 +822,7 @@ public final class ViewRoot extends Handler implements ViewParent, View.AttachIn
                 mDrawingAllowed = true;
             }
 
-            boolean hwIntialized = false;
+            boolean hwInitialized = false;
             boolean contentInsetsChanged = false;
             boolean visibleInsetsChanged;
             boolean hadSurface = mSurface.isValid();
@@ -887,7 +887,7 @@ public final class ViewRoot extends Handler implements ViewParent, View.AttachIn
                         mPreviousTransparentRegion.setEmpty();
 
                         if (mAttachInfo.mHardwareRenderer != null) {
-                            hwIntialized = mAttachInfo.mHardwareRenderer.initialize(mHolder);
+                            hwInitialized = mAttachInfo.mHardwareRenderer.initialize(mHolder);
                         }
                     }
                 } else if (!mSurface.isValid()) {
@@ -935,6 +935,11 @@ public final class ViewRoot extends Handler implements ViewParent, View.AttachIn
                             }
                         }
                         surfaceChanged = true;
+
+                        if (mAttachInfo.mHardwareRenderer != null) {
+                            // This will bail out early if already initialized
+                            mAttachInfo.mHardwareRenderer.initialize(mHolder);
+                        }
                     }
                     if (surfaceChanged) {
                         mSurfaceHolderCallback.surfaceChanged(mSurfaceHolder,
@@ -965,7 +970,7 @@ public final class ViewRoot extends Handler implements ViewParent, View.AttachIn
                 }
             }
 
-            if (hwIntialized || (windowShouldResize && mAttachInfo.mHardwareRenderer != null)) {
+            if (hwInitialized || (windowShouldResize && mAttachInfo.mHardwareRenderer != null)) {
                 mAttachInfo.mHardwareRenderer.setup(mWidth, mHeight);
             }
 
@@ -1795,7 +1800,8 @@ public final class ViewRoot extends Handler implements ViewParent, View.AttachIn
                     boolean inTouchMode = msg.arg2 != 0;
                     ensureTouchModeLocally(inTouchMode);
 
-                    if (mAttachInfo.mHardwareRenderer != null) {
+                    if (mAttachInfo.mHardwareRenderer != null &&
+                            mSurface != null && mSurface.isValid()) {
                         mAttachInfo.mHardwareRenderer.initializeIfNeeded(mWidth, mHeight,
                                 mAttachInfo, mHolder);
                     }