Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Skip tracing missing binder txn names" am: da1c78d158

Browse Source 
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2254719

Change-Id: I56ebf652bb9b73772df918aebb268caa7bf3f20a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
This commit is contained in:
Zimuzo Ezeozue
2022-10-19 17:45:34 +00:00
committed by Automerger Merge Worker
parent 7a54741e61 da1c78d158
commit c3355df5da
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
core/java/android/os/Binder.java
View File

@@ -1241,8 +1241,21 @@ public class Binder implements IBinder {
// If the call was {@link IBinder#FLAG_ONEWAY} then these exceptions // If the call was {@link IBinder#FLAG_ONEWAY} then these exceptions
// disappear into the ether. // disappear into the ether.
final boolean tagEnabled = Trace.isTagEnabled(Trace.TRACE_TAG_AIDL); final boolean tagEnabled = Trace.isTagEnabled(Trace.TRACE_TAG_AIDL);
final boolean hasFullyQualifiedName = getMaxTransactionId() > 0;
final String transactionTraceName; final String transactionTraceName;
if (tagEnabled) {
if (tagEnabled && hasFullyQualifiedName) {
// If tracing enabled and we have a fully qualified name, fetch the name
transactionTraceName = getTransactionTraceName(code);
} else if (tagEnabled && isStackTrackingEnabled()) {
// If tracing is enabled and we *don't* have a fully qualified name, fetch the
// 'best effort' name only for stack tracking. This works around noticeable perf impact
// on low latency binder calls (<100us). The tracing call itself is between (1-10us) and
// the perf impact can be quite noticeable while benchmarking such binder calls.
// The primary culprits are ContentProviders and Cursors which convenienty don't
// autogenerate their AIDL and hence will not have a fully qualified name.
//
// TODO(b/253426478): Relax this constraint after a more robust fix
transactionTraceName = getTransactionTraceName(code); transactionTraceName = getTransactionTraceName(code);
} else { } else {
transactionTraceName = null; transactionTraceName = null;