From 528e947ed28687d89f2b8e459b8e782d2fe9b392 Mon Sep 17 00:00:00 2001
From: Jack Yu <jackyu@google.com>
Date: Sat, 3 Dec 2022 18:42:24 -0800
Subject: [PATCH 1/2] Added sync update database support

Added a config allowing updating subscription
database synchronously or asynchronously.

Test: atest FrameworksTelephonyTests
Bug: 239607619
Merged-In: I639a73a2213eb4a3030ce1398c441a552ab654cf
Change-Id: I639a73a2213eb4a3030ce1398c441a552ab654cf
---
 core/res/res/values/config_telephony.xml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/core/res/res/values/config_telephony.xml b/core/res/res/values/config_telephony.xml
index a1d73ff25cb81..94cf1b2ada0e2 100644
--- a/core/res/res/values/config_telephony.xml
+++ b/core/res/res/values/config_telephony.xml
@@ -117,4 +117,9 @@
     <!-- Whether using the new SubscriptionManagerService or the old SubscriptionController -->
     <bool name="config_using_subscription_manager_service">false</bool>
     <java-symbol type="bool" name="config_using_subscription_manager_service" />
+
+    <!-- Whether asynchronously update the subscription database or not. Async mode increases
+         the performance, but sync mode reduces the chance of database/cache out-of-sync. -->
+    <bool name="config_subscription_database_async_update">true</bool>
+    <java-symbol type="bool" name="config_subscription_database_async_update" />
 </resources>

From 8f04afbfa29ecf8b930278d43d590bb4af06abd5 Mon Sep 17 00:00:00 2001
From: Jack Yu <jackyu@google.com>
Date: Sun, 4 Dec 2022 18:04:33 -0800
Subject: [PATCH 2/2] Added setIconTint

Test: atest FrameworksTelephonyTests
Bug: 239607619#
Merged-In: If6b3c99c35e4b06c6d6085abe5737583bfc8b665
Change-Id: If6b3c99c35e4b06c6d6085abe5737583bfc8b665
---
 telephony/java/android/telephony/SubscriptionManager.java | 4 ++--
 telephony/java/com/android/internal/telephony/ISub.aidl   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/telephony/java/android/telephony/SubscriptionManager.java b/telephony/java/android/telephony/SubscriptionManager.java
index 35226c1817edf..089d3dbad9876 100644
--- a/telephony/java/android/telephony/SubscriptionManager.java
+++ b/telephony/java/android/telephony/SubscriptionManager.java
@@ -2109,7 +2109,7 @@ public class SubscriptionManager {
     /**
      * Set SIM icon tint color for subscription ID
      * @param tint the RGB value of icon tint color of the SIM
-     * @param subId the unique Subscritpion ID in database
+     * @param subId the unique subscription ID in database
      * @return the number of records updated
      * @hide
      */
@@ -2117,7 +2117,7 @@ public class SubscriptionManager {
     public int setIconTint(@ColorInt int tint, int subId) {
         if (VDBG) logd("[setIconTint]+ tint:" + tint + " subId:" + subId);
         return setSubscriptionPropertyHelper(subId, "setIconTint",
-                (iSub)-> iSub.setIconTint(tint, subId)
+                (iSub)-> iSub.setIconTint(subId, tint)
         );
     }
 
diff --git a/telephony/java/com/android/internal/telephony/ISub.aidl b/telephony/java/com/android/internal/telephony/ISub.aidl
index 5173405ac17d6..e9cea6843a829 100644
--- a/telephony/java/com/android/internal/telephony/ISub.aidl
+++ b/telephony/java/com/android/internal/telephony/ISub.aidl
@@ -135,11 +135,11 @@ interface ISub {
 
     /**
      * Set SIM icon tint color by simInfo index
-     * @param tint the icon tint color of the SIM
      * @param subId the unique SubscriptionInfo index in database
+     * @param tint the icon tint color of the SIM
      * @return the number of records updated
      */
-    int setIconTint(int tint, int subId);
+    int setIconTint(int subId, int tint);
 
     /**
      * Set display name by simInfo index with name source