From 7885381f9b004fe549f9900a4f01a9d85aaca601 Mon Sep 17 00:00:00 2001 From: Andrei Popescu Date: Mon, 28 Sep 2009 12:42:02 +0100 Subject: [PATCH] Handle the case where GoogleLocationSettingObserver::onChange is called after GoogleLocationSettingObserver::doNotObserve(). Fixes http://b/issue?id=2147888 --- core/java/android/webkit/GoogleLocationSettingManager.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/core/java/android/webkit/GoogleLocationSettingManager.java b/core/java/android/webkit/GoogleLocationSettingManager.java index 1b6e77cb764c4..508df3b5ac856 100644 --- a/core/java/android/webkit/GoogleLocationSettingManager.java +++ b/core/java/android/webkit/GoogleLocationSettingManager.java @@ -200,7 +200,11 @@ class GoogleLocationSettingManager { @Override public void onChange(boolean selfChange) { - maybeApplySetting(mContext); + // This may come after the call to doNotObserve() above, + // so mContext may be null. + if (mContext != null) { + maybeApplySetting(mContext); + } } } }