From 5c43ec9328ba98fa88acc452b140f2d682a3042c Mon Sep 17 00:00:00 2001 From: Adam Powell Date: Tue, 8 May 2012 16:55:20 -0700 Subject: [PATCH] Fix bug in TaskStackBuilder#addParentStack Don't assume the initial component has a valid parent specified. Bug 6464209 Change-Id: I22aa4c0e667ea85dc46ad7320f4a9f52117af520 --- core/java/android/app/TaskStackBuilder.java | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/core/java/android/app/TaskStackBuilder.java b/core/java/android/app/TaskStackBuilder.java index e546f6c584f48..14c573672faef 100644 --- a/core/java/android/app/TaskStackBuilder.java +++ b/core/java/android/app/TaskStackBuilder.java @@ -196,18 +196,12 @@ public class TaskStackBuilder { try { ActivityInfo info = pm.getActivityInfo(sourceActivityName, 0); String parentActivity = info.parentActivityName; - Intent parent = new Intent().setComponent( - new ComponentName(info.packageName, parentActivity)); - while (parent != null) { + while (parentActivity != null) { + Intent parent = new Intent().setComponent( + new ComponentName(info.packageName, parentActivity)); mIntents.add(insertAt, parent); info = pm.getActivityInfo(parent.getComponent(), 0); parentActivity = info.parentActivityName; - if (parentActivity != null) { - parent = new Intent().setComponent( - new ComponentName(info.packageName, parentActivity)); - } else { - parent = null; - } } } catch (NameNotFoundException e) { Log.e(TAG, "Bad ComponentName while traversing activity parent metadata");