From 8fd0cca41a5e62d660128727f0707953a02bc260 Mon Sep 17 00:00:00 2001
From: Selim Cinek <cinek@google.com>
Date: Mon, 10 Jun 2019 21:01:18 -0700
Subject: [PATCH] Fixed a bug where the icons where clipped off with owner info

Because we were only fading out the owner info, but modifying
its height, the icons would be clipped off.

Fixes: 134814774
Test: atest SystemUITests
Change-Id: If708ef17a327d220f6c21a0b9df866a215adbeb8
---
 .../SystemUI/res-keyguard/layout/keyguard_status_view.xml  | 2 ++
 .../src/com/android/keyguard/KeyguardStatusView.java       | 7 +++++++
 2 files changed, 9 insertions(+)

diff --git a/packages/SystemUI/res-keyguard/layout/keyguard_status_view.xml b/packages/SystemUI/res-keyguard/layout/keyguard_status_view.xml
index a983b05620b44..e08a27779da5e 100644
--- a/packages/SystemUI/res-keyguard/layout/keyguard_status_view.xml
+++ b/packages/SystemUI/res-keyguard/layout/keyguard_status_view.xml
@@ -30,6 +30,8 @@
         android:id="@+id/status_view_container"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
+        android:clipChildren="false"
+        android:clipToPadding="false"
         android:orientation="vertical">
         <TextView
             android:id="@+id/logout"
diff --git a/packages/SystemUI/src/com/android/keyguard/KeyguardStatusView.java b/packages/SystemUI/src/com/android/keyguard/KeyguardStatusView.java
index a7fe607b0e877..65c80e22b1e14 100644
--- a/packages/SystemUI/src/com/android/keyguard/KeyguardStatusView.java
+++ b/packages/SystemUI/src/com/android/keyguard/KeyguardStatusView.java
@@ -61,6 +61,7 @@ public class KeyguardStatusView extends GridLayout implements
     private KeyguardClockSwitch mClockView;
     private TextView mOwnerInfo;
     private KeyguardSliceView mKeyguardSlice;
+    private View mNotificationIcons;
     private Runnable mPendingMarqueeStart;
     private Handler mHandler;
 
@@ -173,6 +174,7 @@ public class KeyguardStatusView extends GridLayout implements
         super.onFinishInflate();
         mStatusViewContainer = findViewById(R.id.status_view_container);
         mLogoutView = findViewById(R.id.logout);
+        mNotificationIcons = findViewById(R.id.clock_notification_icon_container);
         if (mLogoutView != null) {
             mLogoutView.setOnClickListener(this::onLogoutClicked);
         }
@@ -412,6 +414,11 @@ public class KeyguardStatusView extends GridLayout implements
             int expanded = mOwnerInfo.getBottom() + mOwnerInfo.getPaddingBottom();
             int toRemove = (int) ((expanded - collapsed) * ratio);
             setBottom(getMeasuredHeight() - toRemove);
+            // We're using scrolling in order not to overload the translation which is used
+            // when appearing the icons
+            mNotificationIcons.setScrollY(toRemove);
+        } else {
+            mNotificationIcons.setScrollY(0);
         }
     }