From bd114eb6fbac193994a13b473ee68d388b8b3999 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A1s=20Kurucz?= Date: Fri, 5 May 2023 10:17:33 +0000 Subject: [PATCH] Update the Aod Icon colors after the HUN->AOD transition The NotificationAreaController is responsible for adding the StatusBarIconViews to their appropriate container and update their looks. An icon is usually added through updateNotificationIcons(List entries), which adds the icons and updates their colors. It works well if AOD icons are added through this path. However there is another path through onFullyHiddenChanged(boolean fullyHidden) and if an AOD icon becomes visible during this update, we miss to update its color. In case of black PNG icons it resulted in an _invisible_ notification on the AOD. To trigger this path: - show aod - turn off faceauth bypass - post a Pulsing notif with a black PNG icon Fixes: 276353191 Test: post notifs on AOD and observe their color Change-Id: I0c1e97e9862d8d100e8710f6d825200603f0b2a4 --- .../systemui/statusbar/phone/NotificationIconAreaController.java | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationIconAreaController.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationIconAreaController.java index 55dc18859c25a..3a906e0d46cc7 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationIconAreaController.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationIconAreaController.java @@ -604,6 +604,7 @@ public class NotificationIconAreaController implements } updateAodIconsVisibility(animate, false /* force */); updateAodNotificationIcons(); + updateAodIconColors(); } @Override