From a13ad4311c1a661078e2fc4f3f17bdf8d1f4259d Mon Sep 17 00:00:00 2001 From: Ashwini Oruganti Date: Sat, 5 Dec 2020 21:18:53 -0800 Subject: [PATCH] SyncManager: Mark unaudited PendingIntents with FLAG_MUTABLE_UNAUDITED These PIs need an explicit mutability flag. This temporay flag is being used to mark these points in code and should be replaced ASAP. See go/immutable-pendingintents for more context. Bug: 160794467 Test: TH Exempt-From-Owner-Approval: noop change Change-Id: I3e2759285cf544c25a4f461f6cbdf62bc3f80932 --- .../core/java/com/android/server/content/SyncManager.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/services/core/java/com/android/server/content/SyncManager.java b/services/core/java/com/android/server/content/SyncManager.java index 0b2d4d70ae1e0..6ae410a497861 100644 --- a/services/core/java/com/android/server/content/SyncManager.java +++ b/services/core/java/com/android/server/content/SyncManager.java @@ -3838,9 +3838,12 @@ public class SyncManager { } UserHandle user = new UserHandle(userId); + // TODO(b/174186839) Please replace FLAG_MUTABLE_UNAUDITED below + // with either FLAG_IMMUTABLE (recommended) or FLAG_MUTABLE. final PendingIntent pendingIntent = PendingIntent .getActivityAsUser(mContext, 0, clickIntent, - PendingIntent.FLAG_CANCEL_CURRENT, null, user); + PendingIntent.FLAG_CANCEL_CURRENT + | PendingIntent.FLAG_MUTABLE_UNAUDITED, null, user); CharSequence tooManyDeletesDescFormat = mContext.getResources().getText( R.string.contentServiceTooManyDeletesNotificationDesc);