From e286a1de93a41cc4f2667b4f6c2587c06faa4dbd Mon Sep 17 00:00:00 2001 From: Maryam Date: Wed, 14 Sep 2022 12:49:20 -0700 Subject: [PATCH] Fixing input coordinates discrepancy Their was a input coordinate discrepancy for dialogs when we use the wm caption in the shell. Test: tested manually on multiple builds Bug: 244190356 Bug: 243950192 Change-Id: I84cf95a933e90062f20978e4e1f83276c100c326 --- core/java/android/view/InsetsSource.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/java/android/view/InsetsSource.java b/core/java/android/view/InsetsSource.java index 583252756b926..c8c941a220f0f 100644 --- a/core/java/android/view/InsetsSource.java +++ b/core/java/android/view/InsetsSource.java @@ -22,6 +22,7 @@ import static android.view.InsetsSourceProto.VISIBLE; import static android.view.InsetsSourceProto.VISIBLE_FRAME; import static android.view.InsetsState.ITYPE_CAPTION_BAR; import static android.view.InsetsState.ITYPE_IME; +import static android.view.ViewRootImpl.CAPTION_ON_SHELL; import android.annotation.NonNull; import android.annotation.Nullable; @@ -148,7 +149,7 @@ public class InsetsSource implements Parcelable { // During drag-move and drag-resizing, the caption insets position may not get updated // before the app frame get updated. To layout the app content correctly during drag events, // we always return the insets with the corresponding height covering the top. - if (getType() == ITYPE_CAPTION_BAR) { + if (!CAPTION_ON_SHELL && getType() == ITYPE_CAPTION_BAR) { return Insets.of(0, frame.height(), 0, 0); } // Checks for whether there is shared edge with insets for 0-width/height window.