From 000011113f207f6ad88130ae7e7ad2650483324b Mon Sep 17 00:00:00 2001 From: Billy Lau Date: Tue, 7 Feb 2023 15:20:16 -0600 Subject: [PATCH] BinaryTransparencyService: fix `getOriginalApexPreinstalledLocation` Currently, the `getOriginalApexPreinstalledLocation` method takes two parameters but the second parameter is never used. In this change, we remove the second (unused) parameter and fixed the call site. Bug: 266033262 Test: atest BinaryTransparencyServiceTest Change-Id: If5df7ff1e8264cf90899cbd0034f58e4c2fd246c --- .../java/com/android/server/BinaryTransparencyService.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/services/core/java/com/android/server/BinaryTransparencyService.java b/services/core/java/com/android/server/BinaryTransparencyService.java index fc81675682b69..eafd3e0ab3e7f 100644 --- a/services/core/java/com/android/server/BinaryTransparencyService.java +++ b/services/core/java/com/android/server/BinaryTransparencyService.java @@ -584,7 +584,7 @@ public class BinaryTransparencyService extends SystemService { + packageInfo.applicationInfo.sourceDir); if (packageInfo.applicationInfo.sourceDir.startsWith("/data/apex/")) { String origPackageFilepath = getOriginalApexPreinstalledLocation( - packageInfo.packageName, packageInfo.applicationInfo.sourceDir); + packageInfo.packageName); pw.println("|--> Pre-installed package install location: " + origPackageFilepath); @@ -1628,8 +1628,7 @@ public class BinaryTransparencyService extends SystemService { } @NonNull - private String getOriginalApexPreinstalledLocation(String packageName, - String currentInstalledLocation) { + private String getOriginalApexPreinstalledLocation(String packageName) { try { final String moduleName = apexPackageNameToModuleName(packageName); IApexService apexService = IApexService.Stub.asInterface(