From be73c90d7bed293283eabd890cd9214b9dbd1b4a Mon Sep 17 00:00:00 2001 From: Brian Julian Date: Wed, 7 Dec 2022 15:58:53 +0000 Subject: [PATCH] Renames addMslAltitude method in AltitudeConverter to addMslAltitudeToLocation, and updates Javadoc to use @throws. Relnote: N/A Bug: 261696975 Test: atest CtsLocationNoneTestCases Change-Id: I01c9c640eba6ab49b364f3aadcf86701f8aefb95 --- core/api/current.txt | 2 +- .../location/altitude/AltitudeConverter.java | 19 ++++++++----------- 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/core/api/current.txt b/core/api/current.txt index 434b60dd144a7..6803eae328761 100644 --- a/core/api/current.txt +++ b/core/api/current.txt @@ -20206,7 +20206,7 @@ package android.location.altitude { public final class AltitudeConverter { ctor public AltitudeConverter(); - method @WorkerThread public void addMslAltitude(@NonNull android.content.Context, @NonNull android.location.Location) throws java.io.IOException; + method @WorkerThread public void addMslAltitudeToLocation(@NonNull android.content.Context, @NonNull android.location.Location) throws java.io.IOException; } } diff --git a/location/java/android/location/altitude/AltitudeConverter.java b/location/java/android/location/altitude/AltitudeConverter.java index 506128e17740e..d46b4d2c3be38 100644 --- a/location/java/android/location/altitude/AltitudeConverter.java +++ b/location/java/android/location/altitude/AltitudeConverter.java @@ -151,20 +151,17 @@ public final class AltitudeConverter { * altitude accuracy if the {@code location} has a finite and non-negative vertical accuracy; * otherwise, does not add a corresponding accuracy. * - *

Must be called off the main thread as data may be loaded from raw assets. Throws an - * {@link IOException} if an I/O error occurs when loading data. + *

Must be called off the main thread as data may be loaded from raw assets. * - *

Throws an {@link IllegalArgumentException} if the {@code location} has an invalid - * latitude, longitude, or altitude above WGS84. Specifically: - * - *

+ * @throws IOException if an I/O error occurs when loading data from raw assets. + * @throws IllegalArgumentException if the {@code location} has an invalid latitude, longitude, + * or altitude above WGS84. Specifically, the latitude must be + * between -90 and 90 (both inclusive), the longitude must be + * between -180 and 180 (both inclusive), and the altitude + * above WGS84 must be finite. */ @WorkerThread - public void addMslAltitude(@NonNull Context context, @NonNull Location location) + public void addMslAltitudeToLocation(@NonNull Context context, @NonNull Location location) throws IOException { validate(location); MapParamsProto params = GeoidHeightMap.getParams(context);