From bcffb9bc20b9f73bf7637fcd93a3217abf6587fd Mon Sep 17 00:00:00 2001 From: "Torne (Richard Coles)" Date: Wed, 22 Mar 2023 17:00:50 -0400 Subject: [PATCH] Update WebView.setWebContentsDebuggingEnabled docs. Update the docs for setWebContentsDebuggingEnabled to mention that this is now enabled by default for debuggable apps, and to hilight that this is sensitive for security. Bug: 266946852 Test: m offline-sdk-docs Change-Id: I5cf180e59ca5c7e8746f092f8f7303a3be107976 --- core/java/android/webkit/WebView.java | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/core/java/android/webkit/WebView.java b/core/java/android/webkit/WebView.java index 0bbaac0fa9870..6523fffc4b91a 100644 --- a/core/java/android/webkit/WebView.java +++ b/core/java/android/webkit/WebView.java @@ -2000,8 +2000,19 @@ public class WebView extends AbsoluteLayout * in order to facilitate debugging of web layouts and JavaScript * code running inside WebViews. Please refer to WebView documentation * for the debugging guide. - * - * The default is {@code false}. + *

+ * In WebView 113.0.5656.0 and later, this is enabled automatically if the + * app is declared as + * + * {@code android:debuggable="true"} in its manifest; otherwise, the + * default is {@code false}. + *

+ * Enabling web contents debugging allows the state of any WebView in the + * app to be inspected and modified by the user via adb. This is a security + * liability and should not be enabled in production builds of apps unless + * this is an explicitly intended use of the app. More info on + * + * secure debug settings. * * @param enabled whether to enable web contents debugging */