From 77835d0184ceb3c4f26816521b8491348b8a8f66 Mon Sep 17 00:00:00 2001 From: Nicolo' Mazzucato Date: Mon, 21 Nov 2022 13:28:31 +0000 Subject: [PATCH] Remove test for QS and QQS constraints New versions of ConstraintLayout can optimize the constraint set. In this test we were asserting that two constraintsSets were the same despite being specified in different ways (in different xmls). version 2.2.0-beta05 ended up optimizing some constraints, making the test fail, despite no (apparent) visual differences. Bug: 259933125 Bug: 259261262 Test: presubmits Change-Id: Icaf6691865b286e960374eae9d3588e13a1087ab --- .../CombinedShadeHeaderConstraintsTest.kt | 20 ------------------- 1 file changed, 20 deletions(-) diff --git a/packages/SystemUI/tests/src/com/android/systemui/shade/CombinedShadeHeaderConstraintsTest.kt b/packages/SystemUI/tests/src/com/android/systemui/shade/CombinedShadeHeaderConstraintsTest.kt index bc17c19df8f50..afb1a04a0ea51 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/shade/CombinedShadeHeaderConstraintsTest.kt +++ b/packages/SystemUI/tests/src/com/android/systemui/shade/CombinedShadeHeaderConstraintsTest.kt @@ -343,26 +343,6 @@ class CombinedShadeHeaderConstraintsTest : SysuiTestCase() { } } - @Test - fun testCheckViewsDontChangeSizeBetweenAnimationConstraints() { - val views = mapOf( - R.id.clock to "clock", - R.id.date to "date", - R.id.statusIcons to "icons", - R.id.privacy_container to "privacy", - R.id.carrier_group to "carriers", - R.id.batteryRemainingIcon to "battery", - ) - views.forEach { (id, name) -> - assertWithMessage("$name changes height") - .that(qqsConstraint.getConstraint(id).layout.mHeight) - .isEqualTo(qsConstraint.getConstraint(id).layout.mHeight) - assertWithMessage("$name changes width") - .that(qqsConstraint.getConstraint(id).layout.mWidth) - .isEqualTo(qsConstraint.getConstraint(id).layout.mWidth) - } - } - @Test fun testEmptyCutoutDateIconsAreConstrainedWidth() { CombinedShadeHeadersConstraintManagerImpl.emptyCutoutConstraints()()