From 6e258a9c8b55b0a0725d5698df0ea1123f77680b Mon Sep 17 00:00:00 2001 From: Martin Stjernholm Date: Fri, 20 Nov 2020 18:49:40 +0000 Subject: [PATCH] Clarify why it's safe to add java.library.path to the classloader namespace. Test: N/A - comment change only Change-Id: I9ae485afc4b6b827c09bb7d65c3987eefd433492 --- core/java/com/android/internal/os/ZygoteInit.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/core/java/com/android/internal/os/ZygoteInit.java b/core/java/com/android/internal/os/ZygoteInit.java index 6a67670d81607..6335baa97e576 100644 --- a/core/java/com/android/internal/os/ZygoteInit.java +++ b/core/java/com/android/internal/os/ZygoteInit.java @@ -631,8 +631,11 @@ public class ZygoteInit { /** * Creates a PathClassLoader for the given class path that is associated with a shared - * namespace, i.e., this classloader can access platform-private native libraries. The - * classloader will use java.library.path as the native library path. + * namespace, i.e., this classloader can access platform-private native libraries. + * + * The classloader will add java.library.path to the native library path for the classloader + * namespace. Since it includes platform locations like /system/lib, this is only appropriate + * for platform code that don't need linker namespace isolation (as opposed to APEXes and apps). */ static ClassLoader createPathClassLoader(String classPath, int targetSdkVersion) { String libraryPath = System.getProperty("java.library.path");