Merge "Rename LockscreenTargetFilter." into tm-qpr-dev

This commit is contained in:
Darrell Shi
2022-08-06 00:43:50 +00:00
committed by Android (Google) Code Review
3 changed files with 13 additions and 13 deletions

View File

@@ -18,7 +18,7 @@ package com.android.systemui.smartspace.dagger
import com.android.systemui.plugins.BcSmartspaceDataPlugin import com.android.systemui.plugins.BcSmartspaceDataPlugin
import com.android.systemui.smartspace.SmartspacePrecondition import com.android.systemui.smartspace.SmartspacePrecondition
import com.android.systemui.smartspace.SmartspaceTargetFilter import com.android.systemui.smartspace.SmartspaceTargetFilter
import com.android.systemui.smartspace.filters.LockscreenTargetFilter import com.android.systemui.smartspace.filters.LockscreenAndDreamTargetFilter
import com.android.systemui.smartspace.preconditions.LockscreenPrecondition import com.android.systemui.smartspace.preconditions.LockscreenPrecondition
import dagger.Binds import dagger.Binds
import dagger.BindsOptionalOf import dagger.BindsOptionalOf
@@ -61,7 +61,7 @@ abstract class SmartspaceModule {
@Binds @Binds
@Named(LOCKSCREEN_SMARTSPACE_TARGET_FILTER) @Named(LOCKSCREEN_SMARTSPACE_TARGET_FILTER)
abstract fun provideLockscreenSmartspaceTargetFilter( abstract fun provideLockscreenSmartspaceTargetFilter(
filter: LockscreenTargetFilter? filter: LockscreenAndDreamTargetFilter?
): SmartspaceTargetFilter? ): SmartspaceTargetFilter?
@Binds @Binds

View File

@@ -32,9 +32,9 @@ import java.util.concurrent.Executor
import javax.inject.Inject import javax.inject.Inject
/** /**
* {@link SmartspaceTargetFilter} for smartspace targets that show above the lockscreen. * {@link SmartspaceTargetFilter} for smartspace targets that show above the lockscreen and dreams.
*/ */
class LockscreenTargetFilter @Inject constructor( class LockscreenAndDreamTargetFilter @Inject constructor(
private val secureSettings: SecureSettings, private val secureSettings: SecureSettings,
private val userTracker: UserTracker, private val userTracker: UserTracker,
private val execution: Execution, private val execution: Execution,

View File

@@ -27,13 +27,14 @@ import android.testing.TestableLooper
import androidx.test.filters.SmallTest import androidx.test.filters.SmallTest
import com.android.systemui.SysuiTestCase import com.android.systemui.SysuiTestCase
import com.android.systemui.settings.UserTracker import com.android.systemui.settings.UserTracker
import com.android.systemui.smartspace.filters.LockscreenTargetFilter import com.android.systemui.smartspace.filters.LockscreenAndDreamTargetFilter
import com.android.systemui.util.concurrency.Execution import com.android.systemui.util.concurrency.Execution
import com.android.systemui.util.mockito.any import com.android.systemui.util.mockito.any
import com.android.systemui.util.mockito.eq import com.android.systemui.util.mockito.eq
import com.android.systemui.util.mockito.withArgCaptor import com.android.systemui.util.mockito.withArgCaptor
import com.android.systemui.util.settings.SecureSettings import com.android.systemui.util.settings.SecureSettings
import com.google.common.truth.Truth.assertThat import com.google.common.truth.Truth.assertThat
import java.util.concurrent.Executor
import org.junit.Before import org.junit.Before
import org.junit.Test import org.junit.Test
import org.junit.runner.RunWith import org.junit.runner.RunWith
@@ -41,18 +42,17 @@ import org.mockito.ArgumentCaptor
import org.mockito.ArgumentMatchers.anyBoolean import org.mockito.ArgumentMatchers.anyBoolean
import org.mockito.ArgumentMatchers.anyInt import org.mockito.ArgumentMatchers.anyInt
import org.mockito.Mock import org.mockito.Mock
import org.mockito.Mockito.`when`
import org.mockito.Mockito.atLeast import org.mockito.Mockito.atLeast
import org.mockito.Mockito.clearInvocations import org.mockito.Mockito.clearInvocations
import org.mockito.Mockito.mock import org.mockito.Mockito.mock
import org.mockito.Mockito.verify import org.mockito.Mockito.verify
import org.mockito.Mockito.`when`
import org.mockito.MockitoAnnotations import org.mockito.MockitoAnnotations
import java.util.concurrent.Executor
@SmallTest @SmallTest
@TestableLooper.RunWithLooper @TestableLooper.RunWithLooper
@RunWith(AndroidTestingRunner::class) @RunWith(AndroidTestingRunner::class)
class LockscreenTargetFilterTest : SysuiTestCase() { class LockscreenAndDreamTargetFilterTest : SysuiTestCase() {
@Mock @Mock
private lateinit var secureSettings: SecureSettings private lateinit var secureSettings: SecureSettings
@@ -99,7 +99,7 @@ class LockscreenTargetFilterTest : SysuiTestCase() {
`when`(secureSettings `when`(secureSettings
.getIntForUser(eq(setting) ?: setting, anyInt(), anyInt())) .getIntForUser(eq(setting) ?: setting, anyInt(), anyInt()))
.thenReturn(0) .thenReturn(0)
var filter = LockscreenTargetFilter(secureSettings, userTracker, execution, handler, var filter = LockscreenAndDreamTargetFilter(secureSettings, userTracker, execution, handler,
contentResolver, uiExecution) contentResolver, uiExecution)
filter.addListener(listener) filter.addListener(listener)
@@ -132,7 +132,7 @@ class LockscreenTargetFilterTest : SysuiTestCase() {
`when`(secureSettings `when`(secureSettings
.getIntForUser(eq(setting) ?: setting, anyInt(), anyInt())) .getIntForUser(eq(setting) ?: setting, anyInt(), anyInt()))
.thenReturn(0) .thenReturn(0)
var filter = LockscreenTargetFilter(secureSettings, userTracker, execution, handler, var filter = LockscreenAndDreamTargetFilter(secureSettings, userTracker, execution, handler,
contentResolver, uiExecution) contentResolver, uiExecution)
filter.addListener(listener) filter.addListener(listener)