From 7080b677a55cf2797e63675f047451565cddcb01 Mon Sep 17 00:00:00 2001 From: Marcin Oczeretko Date: Fri, 20 Nov 2020 15:26:38 +0000 Subject: [PATCH] Add comments to the arguments passed to FrameTracker Test: n/a Change-Id: I2bca428d7a92006fb370a8608696b34b77a35941 --- .../src/com/android/internal/jank/FrameTrackerTest.java | 3 ++- .../android/internal/jank/InteractionJankMonitorTest.java | 6 ++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/core/tests/coretests/src/com/android/internal/jank/FrameTrackerTest.java b/core/tests/coretests/src/com/android/internal/jank/FrameTrackerTest.java index 2402420e1bc1a..7f7bfa3c5e3df 100644 --- a/core/tests/coretests/src/com/android/internal/jank/FrameTrackerTest.java +++ b/core/tests/coretests/src/com/android/internal/jank/FrameTrackerTest.java @@ -77,7 +77,8 @@ public class FrameTrackerTest { Session session = new Session(CUJ_NOTIFICATION_SHADE_EXPAND_COLLAPSE); mTracker = Mockito.spy( - new FrameTracker(session, handler, mRenderer, mWrapper, 1, -1)); + new FrameTracker(session, handler, mRenderer, mWrapper, + /*traceThresholdMissedFrames=*/ 1, /*traceThresholdFrameTimeMillis=*/ -1)); doNothing().when(mTracker).triggerPerfetto(); } diff --git a/core/tests/coretests/src/com/android/internal/jank/InteractionJankMonitorTest.java b/core/tests/coretests/src/com/android/internal/jank/InteractionJankMonitorTest.java index 474cb1d7ed967..0ef5643b09053 100644 --- a/core/tests/coretests/src/com/android/internal/jank/InteractionJankMonitorTest.java +++ b/core/tests/coretests/src/com/android/internal/jank/InteractionJankMonitorTest.java @@ -94,7 +94,8 @@ public class InteractionJankMonitorTest { Session session = new Session(CUJ_NOTIFICATION_SHADE_EXPAND_COLLAPSE); FrameTracker tracker = spy(new FrameTracker(session, mWorker.getThreadHandler(), new ThreadedRendererWrapper(mView.getThreadedRenderer()), - new FrameMetricsWrapper(), 1, -1)); + new FrameMetricsWrapper(), /*traceThresholdMissedFrames=*/ 1, + /*traceThresholdFrameTimeMillis=*/ -1)); doReturn(tracker).when(monitor).createFrameTracker(any()); // Simulate a trace session and see if begin / end are invoked. @@ -150,7 +151,8 @@ public class InteractionJankMonitorTest { Session session = new Session(CUJ_NOTIFICATION_SHADE_EXPAND_COLLAPSE); FrameTracker tracker = spy(new FrameTracker(session, mWorker.getThreadHandler(), new ThreadedRendererWrapper(mView.getThreadedRenderer()), - new FrameMetricsWrapper(), 1, -1)); + new FrameMetricsWrapper(), /*traceThresholdMissedFrames=*/ 1, + /*traceThresholdFrameTimeMillis=*/ -1)); doReturn(tracker).when(monitor).createFrameTracker(any()); assertThat(monitor.begin(session.getCuj())).isTrue();