Merge "Apilint: Enforce final builders"

am: 2886d307bd Change-Id: I065ff3fede26d527860606ee60b2b6ca8a6d4fbd
2019-02-28 02:10:24 -08:00
parent 29812e6a31 2886d307bd
commit bb74d55781
1 changed files with 3 additions and 0 deletions
--- a/tools/apilint/apilint.py
+++ b/tools/apilint/apilint.py
@@ -1109,6 +1109,9 @@ def verify_builder(clazz):
    if not has_build:
        warn(clazz, None, None, "Missing build() method")

+    if "final" not in clazz.split:
+        error(clazz, None, None, "Builder should be final")
+

 def verify_aidl(clazz):
    """Catch people exposing raw AIDL."""