From 5acc379c5488e846093efd2347d408069509830a Mon Sep 17 00:00:00 2001 From: Fabrice Di Meglio Date: Mon, 12 Nov 2012 14:08:00 -0800 Subject: [PATCH] Fix bug #7457897 Error icons are not shown in credit card entry form - fix regression: the error icon was no more showing is the widget was not focused Change-Id: I24cc00a0cb79d38e365d413f9820b5a6981de4f4 --- core/java/android/widget/Editor.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/core/java/android/widget/Editor.java b/core/java/android/widget/Editor.java index b1a44c5a89bce..521e68606c671 100644 --- a/core/java/android/widget/Editor.java +++ b/core/java/android/widget/Editor.java @@ -291,6 +291,7 @@ public class Editor { mErrorWasChanged = true; if (mError == null) { + setErrorIcon(null); if (mErrorPopup != null) { if (mErrorPopup.isShowing()) { mErrorPopup.dismiss(); @@ -299,10 +300,11 @@ public class Editor { mErrorPopup = null; } - setErrorIcon(null); - } else if (mTextView.isFocused()) { - showError(); + } else { setErrorIcon(icon); + if (mTextView.isFocused()) { + showError(); + } } } @@ -321,8 +323,6 @@ public class Editor { if (mErrorPopup.isShowing()) { mErrorPopup.dismiss(); } - - setErrorIcon(null); } mShowErrorAfterAttach = false;