From 09d2a4b1758c6af933d5642a42c5ca80b88dfdc4 Mon Sep 17 00:00:00 2001 From: Lorenzo Colitti Date: Sat, 29 Jan 2022 21:37:59 +0900 Subject: [PATCH] Move kernelToTag to NetworkStatsFactory. ... to prepare for the deletion of NetworkManagementSocketTagger. Test: atest FrameworksNetTests Change-Id: Id3ad67fa640ddb9ab446e10dcf8e6a588d661dd9 --- .../server/NetworkManagementSocketTagger.java | 13 ------------- .../android/server/net/NetworkStatsFactory.java | 15 +++++++++++++-- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/packages/ConnectivityT/framework-t/src/com/android/server/NetworkManagementSocketTagger.java b/packages/ConnectivityT/framework-t/src/com/android/server/NetworkManagementSocketTagger.java index 8bb12a6defe58..8aca1d67942f3 100644 --- a/packages/ConnectivityT/framework-t/src/com/android/server/NetworkManagementSocketTagger.java +++ b/packages/ConnectivityT/framework-t/src/com/android/server/NetworkManagementSocketTagger.java @@ -111,19 +111,6 @@ public final class NetworkManagementSocketTagger extends SocketTagger { public int statsUid = -1; } - /** - * Convert {@code /proc/} tag format to {@link Integer}. Assumes incoming - * format like {@code 0x7fffffff00000000}. - */ - public static int kernelToTag(String string) { - int length = string.length(); - if (length > 10) { - return Long.decode(string.substring(0, length - 8)).intValue(); - } else { - return 0; - } - } - private static native int native_tagSocketFd(FileDescriptor fd, int tag, int uid); private static native int native_untagSocketFd(FileDescriptor fd); } diff --git a/packages/ConnectivityT/service/src/com/android/server/net/NetworkStatsFactory.java b/packages/ConnectivityT/service/src/com/android/server/net/NetworkStatsFactory.java index 17f3455d20a27..668d1cba921b8 100644 --- a/packages/ConnectivityT/service/src/com/android/server/net/NetworkStatsFactory.java +++ b/packages/ConnectivityT/service/src/com/android/server/net/NetworkStatsFactory.java @@ -22,8 +22,6 @@ import static android.net.NetworkStats.TAG_ALL; import static android.net.NetworkStats.TAG_NONE; import static android.net.NetworkStats.UID_ALL; -import static com.android.server.NetworkManagementSocketTagger.kernelToTag; - import android.annotation.NonNull; import android.annotation.Nullable; import android.content.Context; @@ -469,6 +467,19 @@ public class NetworkStatsFactory { } } + /** + * Convert {@code /proc/} tag format to {@link Integer}. Assumes incoming + * format like {@code 0x7fffffff00000000}. + */ + public static int kernelToTag(String string) { + int length = string.length(); + if (length > 10) { + return Long.decode(string.substring(0, length - 8)).intValue(); + } else { + return 0; + } + } + /** * Parse statistics from file into given {@link NetworkStats} object. Values * are expected to monotonically increase since device boot.