From b98f86f3f8822b9594783660d890aa4455423108 Mon Sep 17 00:00:00 2001 From: Jan Sebechlebsky Date: Thu, 13 Apr 2023 10:40:24 +0200 Subject: [PATCH] Optimize attaching / detaching audio mixes. Bug: 278045109 Test: atest AudioHostTest Change-Id: I5fe032b12c0ff02ac65790a78f5f3cf329c01d55 --- .../core/java/com/android/server/audio/AudioService.java | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/services/core/java/com/android/server/audio/AudioService.java b/services/core/java/com/android/server/audio/AudioService.java index ac55f28a8ab00..93196699e957e 100644 --- a/services/core/java/com/android/server/audio/AudioService.java +++ b/services/core/java/com/android/server/audio/AudioService.java @@ -12429,20 +12429,16 @@ public class AudioService extends IAudioService.Stub } int addMixes(@NonNull ArrayList mixes) { - // TODO optimize to not have to unregister the mixes already in place synchronized (mMixes) { - mAudioSystem.registerPolicyMixes(mMixes, false); this.add(mixes); - return mAudioSystem.registerPolicyMixes(mMixes, true); + return mAudioSystem.registerPolicyMixes(mixes, true); } } int removeMixes(@NonNull ArrayList mixes) { - // TODO optimize to not have to unregister the mixes already in place synchronized (mMixes) { - mAudioSystem.registerPolicyMixes(mMixes, false); this.remove(mixes); - return mAudioSystem.registerPolicyMixes(mMixes, true); + return mAudioSystem.registerPolicyMixes(mixes, false); } }