From b8aec01e6a8485a6975643199f4d3bc8d03aed81 Mon Sep 17 00:00:00 2001 From: Jeremy Meyer Date: Tue, 20 Sep 2022 20:48:11 +0000 Subject: [PATCH] Avoid unnecessary object creation Without this change there are errors when running with the new version of clang Bug: 247585041 Test: verified that frros used for colors still works, automated tests Change-Id: Iebbef8aaca866c6f34c381792c1e66bd6b2121f0 --- cmds/idmap2/libidmap2/Idmap.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmds/idmap2/libidmap2/Idmap.cpp b/cmds/idmap2/libidmap2/Idmap.cpp index 4efaeea742744..444f91d144a21 100644 --- a/cmds/idmap2/libidmap2/Idmap.cpp +++ b/cmds/idmap2/libidmap2/Idmap.cpp @@ -222,7 +222,7 @@ std::unique_ptr IdmapData::FromBinaryStream(std::istream& strea || !Read32(stream, &entry_count)) { return nullptr; } - target_inline_entries.emplace_back(std::make_tuple(target_entry, entry_offset, entry_count)); + target_inline_entries.emplace_back(target_entry, entry_offset, entry_count); } // Read the inline overlay resource values @@ -241,7 +241,7 @@ std::unique_ptr IdmapData::FromBinaryStream(std::istream& strea || !Read32(stream, &value.data_value)) { return nullptr; } - target_values.emplace_back(std::make_pair(config_index, value)); + target_values.emplace_back(config_index, value); } // Read the configurations