From cb8fcbd8f0d353d7fe57a5c3f2f7f9b4f8d9ae22 Mon Sep 17 00:00:00 2001 From: Emilian Peev Date: Mon, 14 Sep 2020 14:03:03 -0700 Subject: [PATCH] Camera: Clarify camera2 id usage when retrieving camcorder profiles Clarify that camera2 ids can be used to query camcorder profiles as long as the devices are capable of producing color output and are not external. Bug: 168527175 Test: make docs & check generated doc output. Change-Id: Idf4bd3e71577b4fc72a164a2fe77caafdbd293ed --- media/java/android/media/CamcorderProfile.java | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/media/java/android/media/CamcorderProfile.java b/media/java/android/media/CamcorderProfile.java index f898931368045..45f1ca044afb7 100644 --- a/media/java/android/media/CamcorderProfile.java +++ b/media/java/android/media/CamcorderProfile.java @@ -19,6 +19,8 @@ package android.media; import android.compat.annotation.UnsupportedAppUsage; import android.hardware.Camera; import android.hardware.Camera.CameraInfo; +import android.hardware.camera2.CameraManager; +import android.hardware.camera2.CameraMetadata; import android.os.Build; /** @@ -418,7 +420,11 @@ public class CamcorderProfile * resolution and higher audio sampling rate, etc, than those with lower quality * level. * - * @param cameraId the id for the camera + * @param cameraId the id for the camera. Integer camera ids parsed from the list received by + * invoking {@link CameraManager#getCameraIdList} can be used as long as they + * are {@link CameraMetadata#REQUEST_AVAILABLE_CAPABILITIES_BACKWARD_COMPATIBLE} + * and not + * {@link CameraMetadata#INFO_SUPPORTED_HARDWARE_LEVEL_EXTERNAL EXTERNAL}. * @param quality the target quality level for the camcorder profile. * @see #QUALITY_LOW * @see #QUALITY_HIGH @@ -512,7 +518,11 @@ public class CamcorderProfile * @see android.hardware.camera2.CameraManager * @see android.hardware.camera2.CameraCharacteristics * - * @param cameraId the id for the camera + * @param cameraId the id for the camera. Integer camera ids parsed from the list received by + * invoking {@link CameraManager#getCameraIdList} can be used as long as they + * are {@link CameraMetadata#REQUEST_AVAILABLE_CAPABILITIES_BACKWARD_COMPATIBLE} + * and not + * {@link CameraMetadata#INFO_SUPPORTED_HARDWARE_LEVEL_EXTERNAL EXTERNAL}. * @param quality the target quality level for the camcorder profile */ public static boolean hasProfile(int cameraId, int quality) {