From 7ae08a6d79d5e6e3e0529ee890f5ca3eae249637 Mon Sep 17 00:00:00 2001 From: James Dong Date: Wed, 11 Aug 2010 15:58:59 -0700 Subject: [PATCH] Fix a crash due to unnecessary check on the codec config data for H263 video track Change-Id: I00e8b65d25731153e4d9be6a443eeed91c8fb605 --- media/libstagefright/MPEG4Writer.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/media/libstagefright/MPEG4Writer.cpp b/media/libstagefright/MPEG4Writer.cpp index c860c5c50eb3c..1460f379e3ae3 100644 --- a/media/libstagefright/MPEG4Writer.cpp +++ b/media/libstagefright/MPEG4Writer.cpp @@ -1956,11 +1956,11 @@ void MPEG4Writer::Track::writeTrackHeader( mOwner->writeInt16(0x18); // depth mOwner->writeInt16(-1); // predefined - CHECK(mCodecSpecificData); - CHECK(mCodecSpecificDataSize > 0); CHECK(23 + mCodecSpecificDataSize < 128); if (!strcasecmp(MEDIA_MIMETYPE_VIDEO_MPEG4, mime)) { + CHECK(mCodecSpecificData); + CHECK(mCodecSpecificDataSize > 0); mOwner->beginBox("esds"); mOwner->writeInt32(0); // version=0, flags=0