From b64afe17064f126eb782c42a238db65f080fc8f0 Mon Sep 17 00:00:00 2001 From: Dianne Hackborn Date: Tue, 22 Jul 2014 16:29:04 -0700 Subject: [PATCH] Further fix on issue #16013164 Dumb dumb dumb copy/paste error when moving the uid checking up out of the function. Change-Id: I01513ccd80750b724dbfa8d9d7d171819c6b959b --- services/core/java/com/android/server/AppOpsService.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/services/core/java/com/android/server/AppOpsService.java b/services/core/java/com/android/server/AppOpsService.java index 579c449cfe3e8..5a510a9c9f93f 100644 --- a/services/core/java/com/android/server/AppOpsService.java +++ b/services/core/java/com/android/server/AppOpsService.java @@ -371,11 +371,10 @@ public class AppOpsService extends IAppOpsService.Stub { @Override public void setMode(int code, int uid, String packageName, int mode) { - if (Binder.getCallingPid() == Process.myPid()) { - return; + if (Binder.getCallingPid() != Process.myPid()) { + mContext.enforcePermission(android.Manifest.permission.UPDATE_APP_OPS_STATS, + Binder.getCallingPid(), Binder.getCallingUid(), null); } - mContext.enforcePermission(android.Manifest.permission.UPDATE_APP_OPS_STATS, - Binder.getCallingPid(), Binder.getCallingUid(), null); verifyIncomingOp(code); ArrayList repCbs = null; code = AppOpsManager.opToSwitch(code);