Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Simplify synchronized code and add comments" am: 9791b54b88

Browse Source 
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1416212

Change-Id: I9024a3daf944ebeeb7d2c179f51f42b1c62563a9
This commit is contained in:
Treehugger Robot
2020-09-01 19:45:44 +00:00
committed by Automerger Merge Worker
parent b11b8ec3ae 9791b54b88
commit b57f32e68a
1 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
media/java/android/media/AudioSystem.java
View File

@@ -304,6 +304,7 @@ public class AudioSystem
/** @hide Media server died. see ErrorCallback */ /** @hide Media server died. see ErrorCallback */
public static final int AUDIO_STATUS_SERVER_DIED = 100; public static final int AUDIO_STATUS_SERVER_DIED = 100;
// all accesses must be synchronized (AudioSystem.class)
private static ErrorCallback sErrorCallback; private static ErrorCallback sErrorCallback;
/** @hide /** @hide
@@ -340,12 +341,10 @@ public class AudioSystem
@UnsupportedAppUsage @UnsupportedAppUsage
private static void errorCallbackFromNative(int error) private static void errorCallbackFromNative(int error)
{ {
ErrorCallback errorCallback = null; ErrorCallback errorCallback;
synchronized (AudioSystem.class) { synchronized (AudioSystem.class) {
if (sErrorCallback != null) {
errorCallback = sErrorCallback; errorCallback = sErrorCallback;
} }
}
if (errorCallback != null) { if (errorCallback != null) {
errorCallback.onError(error); errorCallback.onError(error);
} }
@@ -364,6 +363,7 @@ public class AudioSystem
//keep in sync with include/media/AudioPolicy.h //keep in sync with include/media/AudioPolicy.h
private final static int DYNAMIC_POLICY_EVENT_MIX_STATE_UPDATE = 0; private final static int DYNAMIC_POLICY_EVENT_MIX_STATE_UPDATE = 0;
// all accesses must be synchronized (AudioSystem.class)
private static DynamicPolicyCallback sDynPolicyCallback; private static DynamicPolicyCallback sDynPolicyCallback;
/** @hide */ /** @hide */
@@ -378,12 +378,10 @@ public class AudioSystem
@UnsupportedAppUsage @UnsupportedAppUsage
private static void dynamicPolicyCallbackFromNative(int event, String regId, int val) private static void dynamicPolicyCallbackFromNative(int event, String regId, int val)
{ {
DynamicPolicyCallback cb = null; DynamicPolicyCallback cb;
synchronized (AudioSystem.class) { synchronized (AudioSystem.class) {
if (sDynPolicyCallback != null) {
cb = sDynPolicyCallback; cb = sDynPolicyCallback;
} }
}
if (cb != null) { if (cb != null) {
switch(event) { switch(event) {
case DYNAMIC_POLICY_EVENT_MIX_STATE_UPDATE: case DYNAMIC_POLICY_EVENT_MIX_STATE_UPDATE:
@@ -426,6 +424,7 @@ public class AudioSystem
int activeSource, String packName); int activeSource, String packName);
} }
// all accesses must be synchronized (AudioSystem.class)
private static AudioRecordingCallback sRecordingCallback; private static AudioRecordingCallback sRecordingCallback;
/** @hide */ /** @hide */
@@ -458,7 +457,7 @@ public class AudioSystem
int source, int portId, boolean silenced, int[] recordingFormat, int source, int portId, boolean silenced, int[] recordingFormat,
AudioEffect.Descriptor[] clientEffects, AudioEffect.Descriptor[] effects, AudioEffect.Descriptor[] clientEffects, AudioEffect.Descriptor[] effects,
int activeSource) { int activeSource) {
AudioRecordingCallback cb = null; AudioRecordingCallback cb;
synchronized (AudioSystem.class) { synchronized (AudioSystem.class) {
cb = sRecordingCallback; cb = sRecordingCallback;
} }