diff --git a/services/core/java/com/android/server/am/ActivityManagerService.java b/services/core/java/com/android/server/am/ActivityManagerService.java index ccaf353607b15..9f31ea8f6bb6f 100644 --- a/services/core/java/com/android/server/am/ActivityManagerService.java +++ b/services/core/java/com/android/server/am/ActivityManagerService.java @@ -398,7 +398,6 @@ import com.android.server.IoThread; import com.android.server.LocalManagerRegistry; import com.android.server.LocalServices; import com.android.server.LockGuard; -import com.android.server.NetworkManagementInternal; import com.android.server.PackageWatchdog; import com.android.server.ServiceThread; import com.android.server.SystemConfig; @@ -416,6 +415,7 @@ import com.android.server.criticalevents.CriticalEventLog; import com.android.server.firewall.IntentFirewall; import com.android.server.graphics.fonts.FontManagerInternal; import com.android.server.job.JobSchedulerInternal; +import com.android.server.net.NetworkManagementInternal; import com.android.server.os.NativeTombstoneManager; import com.android.server.pm.Computer; import com.android.server.pm.Installer; diff --git a/services/core/java/com/android/server/NetworkManagementInternal.java b/services/core/java/com/android/server/net/NetworkManagementInternal.java similarity index 96% rename from services/core/java/com/android/server/NetworkManagementInternal.java rename to services/core/java/com/android/server/net/NetworkManagementInternal.java index f53c454cb917b..492696078e55e 100644 --- a/services/core/java/com/android/server/NetworkManagementInternal.java +++ b/services/core/java/com/android/server/net/NetworkManagementInternal.java @@ -14,7 +14,7 @@ * limitations under the License. */ -package com.android.server; +package com.android.server.net; /** * NetworkManagement local system service interface. diff --git a/services/core/java/com/android/server/NetworkManagementService.java b/services/core/java/com/android/server/net/NetworkManagementService.java similarity index 99% rename from services/core/java/com/android/server/NetworkManagementService.java rename to services/core/java/com/android/server/net/NetworkManagementService.java index fc26f0989f450..acfa66595afa3 100644 --- a/services/core/java/com/android/server/NetworkManagementService.java +++ b/services/core/java/com/android/server/net/NetworkManagementService.java @@ -14,7 +14,7 @@ * limitations under the License. */ -package com.android.server; +package com.android.server.net; import static android.Manifest.permission.CONNECTIVITY_INTERNAL; import static android.net.ConnectivityManager.FIREWALL_CHAIN_DOZABLE; @@ -82,6 +82,8 @@ import com.android.internal.util.HexDump; import com.android.internal.util.Preconditions; import com.android.net.module.util.NetdUtils; import com.android.net.module.util.NetdUtils.ModifyOperation; +import com.android.server.FgThread; +import com.android.server.LocalServices; import com.google.android.collect.Maps; diff --git a/services/core/java/com/android/server/net/TEST_MAPPING b/services/core/java/com/android/server/net/TEST_MAPPING index 4ccf09e5e0207..e0376ed6461b5 100644 --- a/services/core/java/com/android/server/net/TEST_MAPPING +++ b/services/core/java/com/android/server/net/TEST_MAPPING @@ -15,7 +15,7 @@ "presubmit": [ { "name": "FrameworksServicesTests", - "file_patterns": ["(/|^)NetworkPolicy[^/]*\\.java"], + "file_patterns": ["(/|^)Network(Policy|Management)[^/]*\\.java"], "options": [ { "include-filter": "com.android.server.net." diff --git a/services/java/com/android/server/SystemServer.java b/services/java/com/android/server/SystemServer.java index c68eea8f35b93..d89807d918190 100644 --- a/services/java/com/android/server/SystemServer.java +++ b/services/java/com/android/server/SystemServer.java @@ -145,6 +145,7 @@ import com.android.server.logcat.LogcatManagerService; import com.android.server.media.MediaRouterService; import com.android.server.media.metrics.MediaMetricsManagerService; import com.android.server.media.projection.MediaProjectionManagerService; +import com.android.server.net.NetworkManagementService; import com.android.server.net.NetworkPolicyManagerService; import com.android.server.net.watchlist.NetworkWatchlistService; import com.android.server.notification.NotificationManagerService; diff --git a/services/tests/servicestests/src/com/android/server/NetworkManagementServiceTest.java b/services/tests/servicestests/src/com/android/server/net/NetworkManagementServiceTest.java similarity index 98% rename from services/tests/servicestests/src/com/android/server/NetworkManagementServiceTest.java rename to services/tests/servicestests/src/com/android/server/net/NetworkManagementServiceTest.java index 17a587603009a..d9cd77d8cd7c3 100644 --- a/services/tests/servicestests/src/com/android/server/NetworkManagementServiceTest.java +++ b/services/tests/servicestests/src/com/android/server/net/NetworkManagementServiceTest.java @@ -14,7 +14,7 @@ * limitations under the License. */ -package com.android.server; +package com.android.server.net; import static android.net.ConnectivityManager.FIREWALL_CHAIN_DOZABLE; import static android.net.ConnectivityManager.FIREWALL_CHAIN_LOW_POWER_STANDBY; @@ -51,14 +51,13 @@ import android.os.PermissionEnforcer; import android.os.Process; import android.os.RemoteException; import android.permission.PermissionCheckerManager; +import android.platform.test.annotations.Presubmit; import android.test.suitebuilder.annotation.SmallTest; import android.util.ArrayMap; import androidx.test.runner.AndroidJUnit4; import com.android.internal.app.IBatteryStats; -import com.android.server.NetworkManagementService.Dependencies; -import com.android.server.net.BaseNetworkObserver; import org.junit.After; import org.junit.Before; @@ -76,6 +75,7 @@ import java.util.function.BiFunction; */ @RunWith(AndroidJUnit4.class) @SmallTest +@Presubmit public class NetworkManagementServiceTest { private NetworkManagementService mNMService; @Mock private Context mContext; @@ -92,7 +92,7 @@ public class NetworkManagementServiceTest { private final MockDependencies mDeps = new MockDependencies(); private final MockPermissionEnforcer mPermissionEnforcer = new MockPermissionEnforcer(); - private final class MockDependencies extends Dependencies { + private final class MockDependencies extends NetworkManagementService.Dependencies { @Override public IBinder getService(String name) { switch (name) {