From bcadfe0cd5805c331442d2e3509f3d7911050a9b Mon Sep 17 00:00:00 2001 From: Tyler Gunn Date: Fri, 3 Sep 2021 13:53:21 -0700 Subject: [PATCH] Clarify that dialed numbers are unformatted. Adding docs clarification so ImsService impls know they need to format the dialed numbers to E164 or whatever format is required for SIP message generation. Test: Docs only change Fixes: 198818889 Change-Id: Icac9e7e120c83f179f65adb54b87ca224e9b4f71 --- .../java/android/telephony/ims/ImsCallSession.java | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/telephony/java/android/telephony/ims/ImsCallSession.java b/telephony/java/android/telephony/ims/ImsCallSession.java index 0aff99709a52d..dfe5e6c93f53d 100755 --- a/telephony/java/android/telephony/ims/ImsCallSession.java +++ b/telephony/java/android/telephony/ims/ImsCallSession.java @@ -766,7 +766,10 @@ public class ImsCallSession { * The method is only valid to call when the session state is in * {@link ImsCallSession.State#IDLE}. * - * @param callee dialed string to make the call to + * @param callee dial string to make the call to. The platform passes the dialed number + * entered by the user as-is. The {@link ImsService} should ensure that the + * number is formatted in SIP messages appropriately (e.g. using + * {@link android.telephony.PhoneNumberUtils#formatNumberToE164(String, String)}). * @param profile call profile to make the call with the specified service type, * call type and media information * @see Listener#callSessionStarted, Listener#callSessionStartFailed @@ -788,7 +791,10 @@ public class ImsCallSession { * The method is only valid to call when the session state is in * {@link ImsCallSession.State#IDLE}. * - * @param participants participant list to initiate an IMS conference call + * @param participants participant list to initiate an IMS conference call. The platform passes + * the dialed numbers entered by the user as-is. The {@link ImsService} should + * ensure that the number is formatted in SIP messages appropriately (e.g. using + * {@link android.telephony.PhoneNumberUtils#formatNumberToE164(String, String)}). * @param profile call profile to make the call with the specified service type, * call type and media information * @see Listener#callSessionStarted, Listener#callSessionStartFailed