Merge "Properly check for SDK before nullifying attribution tag" into sc-dev

This commit is contained in:
TreeHugger Robot
2021-06-15 19:41:24 +00:00
committed by Android (Google) Code Review
2 changed files with 7 additions and 6 deletions

View File

@@ -229,6 +229,7 @@ public abstract class RecognitionService extends Service {
protected abstract void onStopListening(Callback listener);
@Override
@SuppressLint("MissingNullability")
public Context createContext(@NonNull ContextParams contextParams) {
if (contextParams.getNextAttributionSource() != null) {
if (mHandler.getLooper().equals(Looper.myLooper())) {

View File

@@ -4558,15 +4558,15 @@ public class AppOpsService extends IAppOpsService.Stub {
}
try {
if (mPlatformCompat.isChangeEnabledByPackageName(
if (!mPlatformCompat.isChangeEnabledByPackageName(
SECURITY_EXCEPTION_ON_INVALID_ATTRIBUTION_TAG_CHANGE, packageName,
userId) && mPlatformCompat.isChangeEnabledByUid(
userId) || !mPlatformCompat.isChangeEnabledByUid(
SECURITY_EXCEPTION_ON_INVALID_ATTRIBUTION_TAG_CHANGE,
callingUid) && !isAttributionTagValid) {
Slog.e(TAG, msg);
} else {
Slog.e(TAG, msg);
callingUid)) {
// Do not override tags if overriding is not enabled for this package
isAttributionTagValid = true;
}
Slog.e(TAG, msg);
} catch (RemoteException neverHappens) {
}
}