Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

am 8c9283f4: Merge "Fix NullPointerException in ListView"

Browse Source 
* commit '8c9283f41083a20a82ae37eac44b79de6eb3158e':
  Fix NullPointerException in ListView
This commit is contained in:
Adam Powell
2014-12-05 19:32:13 +00:00
committed by Android Git Automerger
parent 66cbec512c 8c9283f410
commit b3b4f83702
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
core/java/android/widget/ListView.java
View File

@@ -2420,10 +2420,15 @@ public class ListView extends AbsListView {
(ViewGroup) selectedView, currentFocus, direction); (ViewGroup) selectedView, currentFocus, direction);
if (nextFocus != null) { if (nextFocus != null) {
// do the math to get interesting rect in next focus' coordinates // do the math to get interesting rect in next focus' coordinates
currentFocus.getFocusedRect(mTempRect); Rect focusedRect = mTempRect;
offsetDescendantRectToMyCoords(currentFocus, mTempRect); if (currentFocus != null) {
offsetRectIntoDescendantCoords(nextFocus, mTempRect); currentFocus.getFocusedRect(focusedRect);
if (nextFocus.requestFocus(direction, mTempRect)) { offsetDescendantRectToMyCoords(currentFocus, focusedRect);
offsetRectIntoDescendantCoords(nextFocus, focusedRect);
} else {
focusedRect = null;
}
if (nextFocus.requestFocus(direction, focusedRect)) {
return true; return true;
} }
} }
@@ -2556,8 +2561,10 @@ public class ListView extends AbsListView {
if (mItemsCanFocus && (focusResult == null) if (mItemsCanFocus && (focusResult == null)
&& selectedView != null && selectedView.hasFocus()) { && selectedView != null && selectedView.hasFocus()) {
final View focused = selectedView.findFocus(); final View focused = selectedView.findFocus();
if (!isViewAncestorOf(focused, this) || distanceToView(focused) > 0) { if (focused != null) {
focused.clearFocus(); if (!isViewAncestorOf(focused, this) || distanceToView(focused) > 0) {
focused.clearFocus();
}
} }
} }