Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Security fix in accessibility - don't read out password. # 2371557" into eclair

Browse Source
This commit is contained in:
Amith Yamasani
2010-01-19 11:50:39 -08:00
committed by Android (Google) Code Review
parent 88e653f665 91ccdb5f10
commit b35b8c1334
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
core/java/android/widget/TextView.java
View File

@@ -6301,7 +6301,8 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener
if (DEBUG_EXTRACT) Log.v(TAG, "beforeTextChanged start=" + start
+ " before=" + before + " after=" + after + ": " + buffer);
if (AccessibilityManager.getInstance(mContext).isEnabled()) {
if (AccessibilityManager.getInstance(mContext).isEnabled()
&& !isPasswordInputType(mInputType)) {
mBeforeText = buffer.toString();
}
@@ -6972,9 +6973,7 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener
@Override
public boolean dispatchPopulateAccessibilityEvent(AccessibilityEvent event) {
boolean isPassword =
(mInputType & (EditorInfo.TYPE_MASK_CLASS | EditorInfo.TYPE_MASK_VARIATION)) ==
(EditorInfo.TYPE_CLASS_TEXT | EditorInfo.TYPE_TEXT_VARIATION_PASSWORD);
final boolean isPassword = isPasswordInputType(mInputType);
if (!isPassword) {
CharSequence text = getText();