Merge "Set FIELD_AUTOFILL_NUM_DATASETS to -1 when service return no response." into pi-dev

This commit is contained in:
Felipe Leme
2018-03-22 04:50:04 +00:00
committed by Android (Google) Code Review
2 changed files with 5 additions and 1 deletions

View File

@@ -3964,7 +3964,8 @@ message MetricsEvent {
// Type TYPE_FAILURE: The request failed
// Package: Package of app that is autofilled
// Tag FIELD_AUTOFILL_SERVICE: Package of service that processed the request
// Tag FIELD_AUTOFILL_NUM_DATASETS: The number of datasets returned (only in success case)
// Tag FIELD_AUTOFILL_NUM_DATASETS: The number of datasets returned in the response, or -1 if
// the service returned a null response.
// NOTE: starting on OS P, it also added:
// Type TYPE_CLOSE: Service returned a null response.
// Tag FIELD_AUTOFILL_NUM_FIELD_CLASSIFICATION_IDS: if service requested field classification,

View File

@@ -596,6 +596,9 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState
}
if (response == null) {
processNullResponseLocked(requestFlags);
mMetricsLogger.write(newLogMaker(MetricsEvent.AUTOFILL_REQUEST, servicePackageName)
.setType(MetricsEvent.TYPE_SUCCESS)
.addTaggedData(MetricsEvent.FIELD_AUTOFILL_NUM_DATASETS, -1));
return;
}