From 5bf0ca1b3a304faf265a6c3e63410b32f4fdb118 Mon Sep 17 00:00:00 2001 From: Jonathan Basseri Date: Wed, 10 Jun 2015 20:52:14 -0700 Subject: [PATCH] Delete TODO and file a bug. This TODO looks more like a feature request, so I filed b/21766386 to evaluate the feature. We should remove the TODO especially because this text is in the public API. Note: I'm not deleting the exact same comment from packages/services/Telephony/res/values/config.xml because the data migrated to CarrierConfigManager is slated to be deleted from config.xml files. Bug: 21571894 Change-Id: Iaba042fb47ade24f5825a48b21960193d322363f --- telephony/java/android/telephony/CarrierConfigManager.java | 5 ----- 1 file changed, 5 deletions(-) diff --git a/telephony/java/android/telephony/CarrierConfigManager.java b/telephony/java/android/telephony/CarrierConfigManager.java index b74b52d71a3c0..21243e2e63815 100644 --- a/telephony/java/android/telephony/CarrierConfigManager.java +++ b/telephony/java/android/telephony/CarrierConfigManager.java @@ -114,11 +114,6 @@ public class CarrierConfigManager { * (Some carriers require that emergency calls *not* be logged, presumably to avoid the risk of * accidental redialing from the call log UI. This is a good idea, so the default here is * false.) - *

- * TODO: on the other hand, it might still be useful to have some record of the emergency calls - * you've made, or to be able to look up the exact date/time of an emergency call. So perhaps we - * should log those calls, but instead fix the call log to disable the "call" button for - * emergency numbers. */ public static final String KEY_ALLOW_EMERGENCY_NUMBERS_IN_CALL_LOG_BOOL = "allow_emergency_numbers_in_call_log_bool";