From b258b21892b5c1143008bcbc4db52a6cc30f8880 Mon Sep 17 00:00:00 2001 From: Jacqueline Bronger Date: Fri, 25 Mar 2022 11:29:48 +0100 Subject: [PATCH] Fix gravity issue when enabling expanded PiP (TV) Bug: 226570096 Fixes: 226570096 Test: manual - open expanded PiP, close PiP, open regular PiP, add expanded aspect ratio to the PiP Change-Id: I951db94a23ee1c885dfa508ea02f1329f604742e --- .../com/android/wm/shell/pip/tv/TvPipBoundsAlgorithm.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libs/WindowManager/Shell/src/com/android/wm/shell/pip/tv/TvPipBoundsAlgorithm.java b/libs/WindowManager/Shell/src/com/android/wm/shell/pip/tv/TvPipBoundsAlgorithm.java index 40a5ae3313ec9..1aefd77419aaf 100644 --- a/libs/WindowManager/Shell/src/com/android/wm/shell/pip/tv/TvPipBoundsAlgorithm.java +++ b/libs/WindowManager/Shell/src/com/android/wm/shell/pip/tv/TvPipBoundsAlgorithm.java @@ -96,12 +96,13 @@ public class TvPipBoundsAlgorithm extends PipBoundsAlgorithm { "%s: getEntryDestinationBounds()", TAG); } updateExpandedPipSize(); - if (mTvPipBoundsState.isTvExpandedPipSupported() + final boolean isPipExpanded = mTvPipBoundsState.isTvExpandedPipSupported() && mTvPipBoundsState.getDesiredTvExpandedAspectRatio() != 0 - && !mTvPipBoundsState.isTvPipManuallyCollapsed()) { + && !mTvPipBoundsState.isTvPipManuallyCollapsed(); + if (isPipExpanded) { updateGravityOnExpandToggled(Gravity.NO_GRAVITY, true); - mTvPipBoundsState.setTvPipExpanded(true); } + mTvPipBoundsState.setTvPipExpanded(isPipExpanded); return getTvPipBounds().getBounds(); }