From 88193b73189f2091652da5047d3f924fb508d42d Mon Sep 17 00:00:00 2001 From: Shuzhen Wang Date: Tue, 11 Feb 2020 10:19:04 -0800 Subject: [PATCH] Camera: Fix an error log spam for external camera External camera's getCameraCharacteristics call may trigger exception via parseInt() call. The exception is catched, and we should not log the message as error. Test: Build Change-Id: Ia858b692ef7622f5fcfbf32cc4fd29574a408731 --- core/java/android/hardware/camera2/CameraManager.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/java/android/hardware/camera2/CameraManager.java b/core/java/android/hardware/camera2/CameraManager.java index c5b9a43fb5235..17c83f3a7eb99 100644 --- a/core/java/android/hardware/camera2/CameraManager.java +++ b/core/java/android/hardware/camera2/CameraManager.java @@ -400,7 +400,8 @@ public final class CameraManager { try { info.setCameraId(Integer.parseInt(cameraId)); } catch (NumberFormatException e) { - Log.e(TAG, "Failed to parse camera Id " + cameraId + " to integer"); + // For external camera, reaching here is expected. + Log.v(TAG, "Failed to parse camera Id " + cameraId + " to integer"); } boolean hasConcurrentStreams = CameraManagerGlobal.get().cameraIdHasConcurrentStreamsLocked(cameraId);