Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Do not need to reset surface as NULL in MediaPlayer's _release. Related to bug 5252296."

Browse Source
This commit is contained in:
Gloria Wang
2011-09-15 10:16:00 -07:00
committed by Android (Google) Code Review
parent c3afd4c60e d59310d086
commit b107c628ba
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
media/jni/android_media_MediaPlayer.cpp
View File

@@ -244,6 +244,15 @@ getVideoSurfaceTexture(JNIEnv* env, jobject thiz) {
return sp<ISurfaceTexture>(p); return sp<ISurfaceTexture>(p);
} }
static void
decVideoSurfaceRef(JNIEnv *env, jobject thiz)
{
sp<ISurfaceTexture> old_st = getVideoSurfaceTexture(env, thiz);
if (old_st != NULL) {
old_st->decStrong(thiz);
}
}
static void static void
setVideoSurface(JNIEnv *env, jobject thiz, jobject jsurface, jboolean mediaPlayerMustBeAlive) setVideoSurface(JNIEnv *env, jobject thiz, jobject jsurface, jboolean mediaPlayerMustBeAlive)
{ {
@@ -255,16 +264,15 @@ setVideoSurface(JNIEnv *env, jobject thiz, jobject jsurface, jboolean mediaPlaye
return; return;
} }
sp<ISurfaceTexture> old_st = getVideoSurfaceTexture(env, thiz); decVideoSurfaceRef(env, thiz);
sp<ISurfaceTexture> new_st; sp<ISurfaceTexture> new_st;
if (jsurface) { if (jsurface) {
sp<Surface> surface(Surface_getSurface(env, jsurface)); sp<Surface> surface(Surface_getSurface(env, jsurface));
new_st = surface->getSurfaceTexture(); new_st = surface->getSurfaceTexture();
new_st->incStrong(thiz); new_st->incStrong(thiz);
} }
if (old_st != NULL) {
old_st->decStrong(thiz);
}
env->SetIntField(thiz, fields.surface_texture, (int)new_st.get()); env->SetIntField(thiz, fields.surface_texture, (int)new_st.get());
// This will fail if the media player has not been initialized yet. This // This will fail if the media player has not been initialized yet. This
@@ -625,7 +633,7 @@ static void
android_media_MediaPlayer_release(JNIEnv *env, jobject thiz) android_media_MediaPlayer_release(JNIEnv *env, jobject thiz)
{ {
LOGV("release"); LOGV("release");
setVideoSurface(env, thiz, NULL, false /* mediaPlayerMustBeAlive */); decVideoSurfaceRef(env, thiz);
sp<MediaPlayer> mp = setMediaPlayer(env, thiz, 0); sp<MediaPlayer> mp = setMediaPlayer(env, thiz, 0);
if (mp != NULL) { if (mp != NULL) {
// this prevents native callbacks after the object is released // this prevents native callbacks after the object is released