From 5f75cbd8593e83eaf17cfac07186a3b6a7b7b1f1 Mon Sep 17 00:00:00 2001
From: Jungshik Jang <jayjang@google.com>
Date: Thu, 7 Aug 2014 12:02:29 +0900
Subject: [PATCH] Use message validator for sending message.

Change-Id: I2ff82c5596e8c78c24189199ede66ee9905b95f5
---
 .../java/com/android/server/hdmi/HdmiCecMessage.java  |  8 --------
 .../com/android/server/hdmi/HdmiControlService.java   | 11 +++++++++--
 2 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/services/core/java/com/android/server/hdmi/HdmiCecMessage.java b/services/core/java/com/android/server/hdmi/HdmiCecMessage.java
index 26071e6decbaa..433e93f0f4ffc 100644
--- a/services/core/java/com/android/server/hdmi/HdmiCecMessage.java
+++ b/services/core/java/com/android/server/hdmi/HdmiCecMessage.java
@@ -28,8 +28,6 @@ import java.util.Arrays;
 public final class HdmiCecMessage {
     public static final byte[] EMPTY_PARAM = EmptyArray.BYTE;
 
-    private static final int MAX_MESSAGE_PARAM_LENGTH = 14;
-
     private final int mSource;
     private final int mDestination;
 
@@ -43,12 +41,6 @@ public final class HdmiCecMessage {
         mSource = source;
         mDestination = destination;
         mOpcode = opcode & 0xFF;
-
-        if (params.length > MAX_MESSAGE_PARAM_LENGTH) {
-            throw new IllegalArgumentException(
-                    "Param length should be at most 13 but current param length is "
-                    + params.length);
-        }
         mParams = Arrays.copyOf(params, params.length);
     }
 
diff --git a/services/core/java/com/android/server/hdmi/HdmiControlService.java b/services/core/java/com/android/server/hdmi/HdmiControlService.java
index 3017d2dbd5ad3..e8d81928d1af2 100644
--- a/services/core/java/com/android/server/hdmi/HdmiControlService.java
+++ b/services/core/java/com/android/server/hdmi/HdmiControlService.java
@@ -517,13 +517,20 @@ public final class HdmiControlService extends SystemService {
     @ServiceThreadOnly
     void sendCecCommand(HdmiCecMessage command, @Nullable SendMessageCallback callback) {
         assertRunOnServiceThread();
-        mCecController.sendCommand(command, callback);
+        if (mMessageValidator.isValid(command)) {
+            mCecController.sendCommand(command, callback);
+        } else {
+            Slog.e(TAG, "Invalid message type:" + command);
+            if (callback != null) {
+                callback.onSendCompleted(Constants.SEND_RESULT_FAILURE);
+            }
+        }
     }
 
     @ServiceThreadOnly
     void sendCecCommand(HdmiCecMessage command) {
         assertRunOnServiceThread();
-        mCecController.sendCommand(command, null);
+        sendCecCommand(command, null);
     }
 
     /**