Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Provide synchronization to setview to avoid NPE"

Browse Source
This commit is contained in:
Treehugger Robot
2016-09-23 12:57:57 +00:00
committed by Gerrit Code Review
parent bc3d106b97 f7abcda5f2
commit b05b93a674
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
core/java/android/view/WindowManagerGlobal.java
View File

@@ -335,20 +335,17 @@ public final class WindowManagerGlobal {
mViews.add(view); mViews.add(view);
mRoots.add(root); mRoots.add(root);
mParams.add(wparams); mParams.add(wparams);
}
// do this last because it fires off messages to start doing things // do this last because it fires off messages to start doing things
try { try {
root.setView(view, wparams, panelParentView); root.setView(view, wparams, panelParentView);
} catch (RuntimeException e) { } catch (RuntimeException e) {
// BadTokenException or InvalidDisplayException, clean up. // BadTokenException or InvalidDisplayException, clean up.
synchronized (mLock) {
final int index = findViewLocked(view, false);
if (index >= 0) { if (index >= 0) {
removeViewLocked(index, true); removeViewLocked(index, true);
} }
throw e;
} }
throw e;
} }
} }