From aff0bc189aa5f0f5affe668db57d9ec3b521ff23 Mon Sep 17 00:00:00 2001 From: Ricky Wai Date: Fri, 23 Mar 2018 18:05:49 +0000 Subject: [PATCH] Suppress expected exception due to missing network_watchlist.xml Test: NULL Bug:73264037 Change-Id: I640ad865fe85191f7d9e5fe887be10884c7bb801 --- .../com/android/server/net/watchlist/WatchlistConfig.java | 4 ++++ .../com/android/server/net/watchlist/WatchlistSettings.java | 6 +++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/services/core/java/com/android/server/net/watchlist/WatchlistConfig.java b/services/core/java/com/android/server/net/watchlist/WatchlistConfig.java index 2714d5e5f605d..d793842093cca 100644 --- a/services/core/java/com/android/server/net/watchlist/WatchlistConfig.java +++ b/services/core/java/com/android/server/net/watchlist/WatchlistConfig.java @@ -107,6 +107,10 @@ class WatchlistConfig { * Reload watchlist by reading config file. */ public void reloadConfig() { + if (!mXmlFile.exists()) { + // No config file + return; + } try (FileInputStream stream = new FileInputStream(mXmlFile)){ final List crc32DomainList = new ArrayList<>(); final List sha256DomainList = new ArrayList<>(); diff --git a/services/core/java/com/android/server/net/watchlist/WatchlistSettings.java b/services/core/java/com/android/server/net/watchlist/WatchlistSettings.java index f5ba889e8cf42..e20a510d888f3 100644 --- a/services/core/java/com/android/server/net/watchlist/WatchlistSettings.java +++ b/services/core/java/com/android/server/net/watchlist/WatchlistSettings.java @@ -87,6 +87,10 @@ class WatchlistSettings { } public void reloadSettings() { + if (!mXmlFile.exists()) { + // No settings config + return; + } try (FileInputStream stream = mXmlFile.openRead()){ XmlPullParser parser = Xml.newPullParser(); parser.setInput(stream, StandardCharsets.UTF_8.name()); @@ -97,7 +101,7 @@ class WatchlistSettings { mPrivacySecretKey = parseSecretKey(parser); } } - Log.i(TAG, "Reload watchlist settings done"); + Slog.i(TAG, "Reload watchlist settings done"); } catch (IllegalStateException | NullPointerException | NumberFormatException | XmlPullParserException | IOException | IndexOutOfBoundsException e) { Slog.e(TAG, "Failed parsing xml", e);