Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge changes from topic "am-1ab9514f-fd12-4093-b1cb-a77e9f0419c9" into cw-f-dev

Browse Source 
* changes:
  [automerger] Check for null-terminator in ResStringPool::string8At am: 5ec65ae909 am: c3d7250b99 am: e2417e6682 am: 0ab4540c41 am: a3f0976937 am: 166aa6e149 am: b7f7f7e14e am: c26b8635b7
  [automerger] Check for null-terminator in ResStringPool::string8At am: 5ec65ae909 am: c3d7250b99 am: e2417e6682 am: 0ab4540c41 am: a3f0976937 am: 166aa6e149 am: b7f7f7e14e
  [automerger] Check for null-terminator in ResStringPool::string8At am: 5ec65ae909 am: c3d7250b99 am: e2417e6682 am: 0ab4540c41 am: a3f0976937 am: 166aa6e149
  [automerger] Check for null-terminator in ResStringPool::string8At am: 5ec65ae909 am: c3d7250b99 am: e2417e6682 am: 0ab4540c41 am: a3f0976937
  [automerger] Check for null-terminator in ResStringPool::string8At am: 5ec65ae909 am: c3d7250b99 am: e2417e6682 am: 0ab4540c41
  [automerger] Check for null-terminator in ResStringPool::string8At am: 5ec65ae909 am: c3d7250b99 am: e2417e6682
  [automerger] Check for null-terminator in ResStringPool::string8At am: 5ec65ae909 am: c3d7250b99
  [automerger] Check for null-terminator in ResStringPool::string8At am: 5ec65ae909
  Check for null-terminator in ResStringPool::string8At
This commit is contained in:
TreeHugger Robot
2018-01-31 22:13:40 +00:00
committed by Android (Google) Code Review
parent 41ee2787b4 afac0f46d9
commit afb1b1aeb6
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libs/androidfw/ResourceTypes.cpp
View File

@@ -807,6 +807,12 @@ const char* ResStringPool::string8At(size_t idx, size_t* outLen) const
*outLen = decodeLength(&str); *outLen = decodeLength(&str);
size_t encLen = decodeLength(&str); size_t encLen = decodeLength(&str);
if ((uint32_t)(str+encLen-strings) < mStringPoolSize) { if ((uint32_t)(str+encLen-strings) < mStringPoolSize) {
// Reject malformed (non null-terminated) strings
if (str[encLen] != 0x00) {
ALOGW("Bad string block: string #%d is not null-terminated",
(int)idx);
return NULL;
}
return (const char*)str; return (const char*)str;
} else { } else {
ALOGW("Bad string block: string #%d extends to %d, past end at %d\n", ALOGW("Bad string block: string #%d extends to %d, past end at %d\n",