From afad4c7fc525d356a95b4c54c443bc3e217bce47 Mon Sep 17 00:00:00 2001 From: wilsonshih Date: Thu, 20 Jan 2022 16:14:18 +0800 Subject: [PATCH] Fixes opening task from Recents can be hidden. The opening task from Recents can be invisible because there would hide the created leash, which should be unnecessary since the recents window animator would handle the cross fade animation. Test: Enable shell transition, enter recents, swipe to right-most page( the page shows "Clear all"), then click the task and verify the task won't become invisible during animation. Test on both NexusLauncher and 3rd-party Launcher. Test: atest FlickerTests:OpenAppFromOverviewTest Test: atest TaplTestsQuickstep Change-Id: I0f7b7855de944c744190f6599ed48490f6e0d9f0 --- .../systemui/shared/system/RemoteTransitionCompat.java | 8 -------- 1 file changed, 8 deletions(-) diff --git a/packages/SystemUI/shared/src/com/android/systemui/shared/system/RemoteTransitionCompat.java b/packages/SystemUI/shared/src/com/android/systemui/shared/system/RemoteTransitionCompat.java index 4500563fc86e4..4f0d759ca1d20 100644 --- a/packages/SystemUI/shared/src/com/android/systemui/shared/system/RemoteTransitionCompat.java +++ b/packages/SystemUI/shared/src/com/android/systemui/shared/system/RemoteTransitionCompat.java @@ -270,7 +270,6 @@ public class RemoteTransitionCompat implements Parcelable { mLeashMap.put(mOpeningLeashes.get(i), target.leash); t.reparent(target.leash, mInfo.getRootLeash()); t.setLayer(target.leash, layer); - t.hide(target.leash); targets[i] = target; } t.apply(); @@ -325,13 +324,6 @@ public class RemoteTransitionCompat implements Parcelable { } } else { wct = null; - if (mOpeningLeashes != null) { - // TODO: the launcher animation should handle this - for (int i = 0; i < mOpeningLeashes.size(); ++i) { - t.show(mOpeningLeashes.get(i)); - t.setAlpha(mOpeningLeashes.get(i), 1.f); - } - } if (mPipTask != null && mPipTransaction != null) { t.show(mInfo.getChange(mPipTask).getLeash()); PictureInPictureSurfaceTransaction.apply(mPipTransaction,