From af950165d55562b5e7956567847f54df491567bf Mon Sep 17 00:00:00 2001 From: Zekan Qian Date: Fri, 9 Dec 2022 15:54:18 +0800 Subject: [PATCH] Rename LocalLogger as DebugLogger & move to Debug folder Bug: 253979024 Test: unit-test & local build gallery Change-Id: Ic2ee1eef3105d6324ca759f8ea45aa56d3ca19d8 --- .../spa/gallery/GallerySpaEnvironment.kt | 4 +-- .../settingslib/spa/debug/DebugLogger.kt | 34 +++++++++++++++++++ .../spa/framework/common/SpaLogger.kt | 12 ------- 3 files changed, 36 insertions(+), 14 deletions(-) create mode 100644 packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/debug/DebugLogger.kt diff --git a/packages/SettingsLib/Spa/gallery/src/com/android/settingslib/spa/gallery/GallerySpaEnvironment.kt b/packages/SettingsLib/Spa/gallery/src/com/android/settingslib/spa/gallery/GallerySpaEnvironment.kt index db4990974e23d..e54e2764bb401 100644 --- a/packages/SettingsLib/Spa/gallery/src/com/android/settingslib/spa/gallery/GallerySpaEnvironment.kt +++ b/packages/SettingsLib/Spa/gallery/src/com/android/settingslib/spa/gallery/GallerySpaEnvironment.kt @@ -17,7 +17,7 @@ package com.android.settingslib.spa.gallery import android.content.Context -import com.android.settingslib.spa.framework.common.LocalLogger +import com.android.settingslib.spa.debug.DebugLogger import com.android.settingslib.spa.framework.common.SettingsPageProviderRepository import com.android.settingslib.spa.framework.common.SpaEnvironment import com.android.settingslib.spa.framework.common.createSettingsPage @@ -83,7 +83,7 @@ class GallerySpaEnvironment(context: Context) : SpaEnvironment(context) { ) } - override val logger = LocalLogger() + override val logger = DebugLogger() override val browseActivityClass = GalleryMainActivity::class.java override val sliceBroadcastReceiverClass = SpaSliceBroadcastReceiver::class.java diff --git a/packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/debug/DebugLogger.kt b/packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/debug/DebugLogger.kt new file mode 100644 index 0000000000000..7d4833635f9db --- /dev/null +++ b/packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/debug/DebugLogger.kt @@ -0,0 +1,34 @@ +/* + * Copyright (C) 2022 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.android.settingslib.spa.debug + +import android.os.Bundle +import android.util.Log +import com.android.settingslib.spa.framework.common.LogCategory +import com.android.settingslib.spa.framework.common.LogEvent +import com.android.settingslib.spa.framework.common.SpaLogger + +class DebugLogger : SpaLogger { + override fun message(tag: String, msg: String, category: LogCategory) { + Log.d("SpaMsg-$category", "[$tag] $msg") + } + + override fun event(id: String, event: LogEvent, category: LogCategory, extraData: Bundle) { + val extraMsg = extraData.toString().removeRange(0, 6) + Log.d("SpaEvent-$category", "[$id] $event $extraMsg") + } +} diff --git a/packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/framework/common/SpaLogger.kt b/packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/framework/common/SpaLogger.kt index 6ecb7fa94c3c7..78df0f27cc6ad 100644 --- a/packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/framework/common/SpaLogger.kt +++ b/packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/framework/common/SpaLogger.kt @@ -17,7 +17,6 @@ package com.android.settingslib.spa.framework.common import android.os.Bundle -import android.util.Log // Defines the category of the log, for quick filter enum class LogCategory { @@ -62,14 +61,3 @@ interface SpaLogger { ) { } } - -class LocalLogger : SpaLogger { - override fun message(tag: String, msg: String, category: LogCategory) { - Log.d("SpaMsg-$category", "[$tag] $msg") - } - - override fun event(id: String, event: LogEvent, category: LogCategory, extraData: Bundle) { - val extraMsg = extraData.toString().removeRange(0, 6) - Log.d("SpaEvent-$category", "[$id] $event $extraMsg") - } -} \ No newline at end of file