Merge changes I2516e8d2,I6c4f5c93 into sc-v2-dev

* changes:
  Don't expand the keyguard if it's fading away.
  Don't play screen off animation if we are upside down unless that's allowed.
This commit is contained in:
TreeHugger Robot
2021-10-11 23:50:51 +00:00
committed by Android (Google) Code Review
2 changed files with 13 additions and 7 deletions

View File

@@ -385,11 +385,16 @@ public abstract class PanelViewController {
final boolean expand; final boolean expand;
if (event.getActionMasked() == MotionEvent.ACTION_CANCEL || forceCancel) { if (event.getActionMasked() == MotionEvent.ACTION_CANCEL || forceCancel) {
// If we get a cancel, put the shade back to the state it was in when the gesture // If the keyguard is fading away, don't expand it again. This can happen if you're
// started // swiping to unlock, the app below the keyguard is in landscape, and the screen
if (onKeyguard) { // rotates while your finger is still down after the swipe to unlock.
if (mKeyguardStateController.isKeyguardFadingAway()) {
expand = false;
} else if (onKeyguard) {
expand = true; expand = true;
} else { } else {
// If we get a cancel, put the shade back to the state it was in when the
// gesture started
expand = !mPanelClosedOnDown; expand = !mPanelClosedOnDown;
} }
} else { } else {

View File

@@ -4,10 +4,10 @@ import android.animation.Animator
import android.animation.AnimatorListenerAdapter import android.animation.AnimatorListenerAdapter
import android.animation.ValueAnimator import android.animation.ValueAnimator
import android.content.Context import android.content.Context
import android.content.res.Configuration
import android.database.ContentObserver import android.database.ContentObserver
import android.os.Handler import android.os.Handler
import android.provider.Settings import android.provider.Settings
import android.view.Surface
import android.view.View import android.view.View
import com.android.systemui.animation.Interpolators import com.android.systemui.animation.Interpolators
import com.android.systemui.dagger.SysUISingleton import com.android.systemui.dagger.SysUISingleton
@@ -239,10 +239,11 @@ class UnlockedScreenOffAnimationController @Inject constructor(
return false return false
} }
// If we're not allowed to rotate the keyguard, then only do the screen off animation if // If we're not allowed to rotate the keyguard, it can only be displayed in zero-degree
// we're in portrait. Otherwise, AOD will animate in sideways, which looks weird. // portrait. If we're in another orientation, disable the screen off animation so we don't
// animate in the keyguard AOD UI sideways or upside down.
if (!keyguardStateController.isKeyguardScreenRotationAllowed && if (!keyguardStateController.isKeyguardScreenRotationAllowed &&
context.resources.configuration.orientation != Configuration.ORIENTATION_PORTRAIT) { context.display.rotation != Surface.ROTATION_0) {
return false return false
} }