Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fix setRecoverySecretTypes to not always set snapshot pending" into pi-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2018-03-27 09:09:54 +00:00
committed by Android (Google) Code Review
parent 51e33d1948 5a1acefb88
commit af13eeb110
2 changed files with 55 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
services/core/java/com/android/server/locksettings/recoverablekeystore/RecoverableKeyStoreManager.java
View File

@@ -382,10 +382,26 @@ public class RecoverableKeyStoreManager {
Preconditions.checkNotNull(secretTypes, "secretTypes is null"); Preconditions.checkNotNull(secretTypes, "secretTypes is null");
int userId = UserHandle.getCallingUserId(); int userId = UserHandle.getCallingUserId();
int uid = Binder.getCallingUid(); int uid = Binder.getCallingUid();
long updatedRows = mDatabase.setRecoverySecretTypes(userId, uid, secretTypes);
if (updatedRows > 0) { int[] currentSecretTypes = mDatabase.getRecoverySecretTypes(userId, uid);
mDatabase.setShouldCreateSnapshot(userId, uid, true); if (Arrays.equals(secretTypes, currentSecretTypes)) {
Log.v(TAG, "Not updating secret types - same as old value.");
return;
} }
long updatedRows = mDatabase.setRecoverySecretTypes(userId, uid, secretTypes);
if (updatedRows < 1) {
throw new ServiceSpecificException(ERROR_SERVICE_INTERNAL_ERROR,
"Database error trying to set secret types.");
}
if (currentSecretTypes.length == 0) {
Log.i(TAG, "Initialized secret types.");
return;
}
Log.i(TAG, "Updated secret types. Snapshot pending.");
mDatabase.setShouldCreateSnapshot(userId, uid, true);
} }
/** /**

37
services/tests/servicestests/src/com/android/server/locksettings/recoverablekeystore/RecoverableKeyStoreManagerTest.java
View File

@@ -879,7 +879,7 @@ public class RecoverableKeyStoreManagerTest {
} }
@Test @Test
public void setRecoverySecretTypes() throws Exception { public void setRecoverySecretTypes_updatesSecretTypes() throws Exception {
int[] types1 = new int[]{11, 2000}; int[] types1 = new int[]{11, 2000};
int[] types2 = new int[]{1, 2, 3}; int[] types2 = new int[]{1, 2, 3};
int[] types3 = new int[]{}; int[] types3 = new int[]{};
@@ -897,6 +897,41 @@ public class RecoverableKeyStoreManagerTest {
types3); types3);
} }
@Test
public void setRecoverySecretTypes_doesNotSetSnapshotPendingIfIniting() throws Exception {
int uid = Binder.getCallingUid();
int userId = UserHandle.getCallingUserId();
int[] secretTypes = new int[] { 101 };
mRecoverableKeyStoreManager.setRecoverySecretTypes(secretTypes);
assertThat(mRecoverableKeyStoreDb.getShouldCreateSnapshot(userId, uid)).isFalse();
}
@Test
public void setRecoverySecretTypes_doesNotSetSnapshotPendingIfSettingSameValue()
throws Exception {
int uid = Binder.getCallingUid();
int userId = UserHandle.getCallingUserId();
int[] secretTypes = new int[] { 101 };
mRecoverableKeyStoreManager.setRecoverySecretTypes(secretTypes);
mRecoverableKeyStoreManager.setRecoverySecretTypes(secretTypes);
assertThat(mRecoverableKeyStoreDb.getShouldCreateSnapshot(userId, uid)).isFalse();
}
@Test
public void setRecoverySecretTypes_setsSnapshotPendingIfUpdatingValue() throws Exception {
int uid = Binder.getCallingUid();
int userId = UserHandle.getCallingUserId();
mRecoverableKeyStoreManager.setRecoverySecretTypes(new int[] { 101 });
mRecoverableKeyStoreManager.setRecoverySecretTypes(new int[] { 102 });
assertThat(mRecoverableKeyStoreDb.getShouldCreateSnapshot(userId, uid)).isTrue();
}
@Test @Test
public void setRecoverySecretTypes_throwsIfNullTypes() throws Exception { public void setRecoverySecretTypes_throwsIfNullTypes() throws Exception {
try { try {