Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "onSavePassword dialog can leak when WebViewClassic is destroyed."

Browse Source
This commit is contained in:
John Reck
2012-08-30 11:00:21 -07:00
committed by android code review
parent 7fecf5f451 8655e9085c
commit ae03afda41
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
core/java/android/webkit/WebViewClassic.java
View File

@@ -686,6 +686,10 @@ public final class WebViewClassic implements WebViewProvider, WebViewProvider.Sc
// It's used to dismiss the dialog in destroy if not done before. // It's used to dismiss the dialog in destroy if not done before.
private AlertDialog mListBoxDialog = null; private AlertDialog mListBoxDialog = null;
// Reference to the save password dialog so it can be dimissed in
// destroy if not done before.
private AlertDialog mSavePasswordDialog = null;
static final String LOGTAG = "webview"; static final String LOGTAG = "webview";
private ZoomManager mZoomManager; private ZoomManager mZoomManager;
@@ -1811,7 +1815,7 @@ public final class WebViewClassic implements WebViewProvider, WebViewProvider.Sc
neverRemember.getData().putString("password", password); neverRemember.getData().putString("password", password);
neverRemember.obj = resumeMsg; neverRemember.obj = resumeMsg;
new AlertDialog.Builder(mContext) mSavePasswordDialog = new AlertDialog.Builder(mContext)
.setTitle(com.android.internal.R.string.save_password_label) .setTitle(com.android.internal.R.string.save_password_label)
.setMessage(com.android.internal.R.string.save_password_message) .setMessage(com.android.internal.R.string.save_password_message)
.setPositiveButton(com.android.internal.R.string.save_password_notnow, .setPositiveButton(com.android.internal.R.string.save_password_notnow,
@@ -1822,6 +1826,7 @@ public final class WebViewClassic implements WebViewProvider, WebViewProvider.Sc
resumeMsg.sendToTarget(); resumeMsg.sendToTarget();
mResumeMsg = null; mResumeMsg = null;
} }
mSavePasswordDialog = null;
} }
}) })
.setNeutralButton(com.android.internal.R.string.save_password_remember, .setNeutralButton(com.android.internal.R.string.save_password_remember,
@@ -1832,6 +1837,7 @@ public final class WebViewClassic implements WebViewProvider, WebViewProvider.Sc
remember.sendToTarget(); remember.sendToTarget();
mResumeMsg = null; mResumeMsg = null;
} }
mSavePasswordDialog = null;
} }
}) })
.setNegativeButton(com.android.internal.R.string.save_password_never, .setNegativeButton(com.android.internal.R.string.save_password_never,
@@ -1842,6 +1848,7 @@ public final class WebViewClassic implements WebViewProvider, WebViewProvider.Sc
neverRemember.sendToTarget(); neverRemember.sendToTarget();
mResumeMsg = null; mResumeMsg = null;
} }
mSavePasswordDialog = null;
} }
}) })
.setOnCancelListener(new OnCancelListener() { .setOnCancelListener(new OnCancelListener() {
@@ -1851,6 +1858,7 @@ public final class WebViewClassic implements WebViewProvider, WebViewProvider.Sc
resumeMsg.sendToTarget(); resumeMsg.sendToTarget();
mResumeMsg = null; mResumeMsg = null;
} }
mSavePasswordDialog = null;
} }
}).show(); }).show();
// Return true so that WebViewCore will pause while the dialog is // Return true so that WebViewCore will pause while the dialog is
@@ -2090,6 +2098,10 @@ public final class WebViewClassic implements WebViewProvider, WebViewProvider.Sc
mListBoxDialog.dismiss(); mListBoxDialog.dismiss();
mListBoxDialog = null; mListBoxDialog = null;
} }
if (mSavePasswordDialog != null) {
mSavePasswordDialog.dismiss();
mSavePasswordDialog = null;
}
if (mWebViewCore != null) { if (mWebViewCore != null) {
// Tell WebViewCore to destroy itself // Tell WebViewCore to destroy itself
synchronized (this) { synchronized (this) {