From 4cf5a75f378b5378c7d06c2140983d7205727225 Mon Sep 17 00:00:00 2001 From: Thomas Stuart Date: Tue, 13 Jun 2023 15:10:21 -0700 Subject: [PATCH] update TelecomManager docs on when to post a CallSytle notif bug: 282997779 Test: build Change-Id: I9c1a3d0ca6e24a5cc6090d7e659329bf19391d1b --- .../java/android/telecom/TelecomManager.java | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/telecomm/java/android/telecom/TelecomManager.java b/telecomm/java/android/telecom/TelecomManager.java index 26590c4704c3e..a72f7806d3ea5 100644 --- a/telecomm/java/android/telecom/TelecomManager.java +++ b/telecomm/java/android/telecom/TelecomManager.java @@ -2097,7 +2097,10 @@ public class TelecomManager { * For a self-managed {@link ConnectionService}, a {@link SecurityException} will be thrown if * the {@link PhoneAccount} has {@link PhoneAccount#CAPABILITY_SELF_MANAGED} and the calling app * does not have {@link android.Manifest.permission#MANAGE_OWN_CALLS}. - * + *

+ *

+ * Note: {@link android.app.Notification.CallStyle} notifications should be posted after + * the call is added to Telecom in order for the notification to be non-dismissible. * @param phoneAccount A {@link PhoneAccountHandle} registered with * {@link #registerPhoneAccount}. * @param extras A bundle that will be passed through to @@ -2345,7 +2348,10 @@ public class TelecomManager { * {@link PhoneAccount} with the {@link PhoneAccount#CAPABILITY_PLACE_EMERGENCY_CALLS} * capability, depending on external factors, such as network conditions and Modem/SIM status. *

- * + *

+ *

+ * Note: {@link android.app.Notification.CallStyle} notifications should be posted after + * the call is placed in order for the notification to be non-dismissible. * @param address The address to make the call to. * @param extras Bundle of extras to use with the call. */ @@ -2679,9 +2685,11 @@ public class TelecomManager { /** * Add a call to the Android system service Telecom. This allows the system to start tracking an - * incoming or outgoing call with the specified {@link CallAttributes}. Once the call is ready - * to be disconnected, use the {@link CallControl#disconnect(DisconnectCause, Executor, - * OutcomeReceiver)} which is provided by the {@code pendingControl#onResult(CallControl)}. + * incoming or outgoing call with the specified {@link CallAttributes}. Once a call is added, + * a {@link android.app.Notification.CallStyle} notification should be posted and when the + * call is ready to be disconnected, use {@link CallControl#disconnect(DisconnectCause, + * Executor, OutcomeReceiver)} which is provided by the + * {@code pendingControl#onResult(CallControl)}. *

*

*