From 9a43192cef11dcc0e2aafc02cc5efe4a572c4301 Mon Sep 17 00:00:00 2001 From: Joshua Trask Date: Thu, 5 May 2022 11:00:03 -0400 Subject: [PATCH] Fix logging crash in ResolverRankerService model This was a regression introduced in ag/17913997 because I missed that the legacy code included the ternary `? 0 : 1` to convert from boolean to int value in this (not-type-safe, see b/231577676) API call. Bug: 231491021 Bug: 231577676 Test: compile/presubmit. This doesn't prove that the fix works (we must just not have coverage, or we would've caught the regression the first time) but it does validate the syntax and confirm that there are no other unintended changes (stray keystrokes...). The fix is trivial; this CL simply restores the exact behavior pre- ag/17913997. Change-Id: I706dee50e074da3ca40cde5b83abfd076a271959 --- .../internal/app/ResolverRankerServiceResolverComparator.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/java/com/android/internal/app/ResolverRankerServiceResolverComparator.java b/core/java/com/android/internal/app/ResolverRankerServiceResolverComparator.java index c5b21ac4da903..e7f80a7f60710 100644 --- a/core/java/com/android/internal/app/ResolverRankerServiceResolverComparator.java +++ b/core/java/com/android/internal/app/ResolverRankerServiceResolverComparator.java @@ -589,7 +589,7 @@ class ResolverRankerServiceResolverComparator extends AbstractResolverComparator MetricsLogger metricsLogger = new MetricsLogger(); LogMaker log = new LogMaker(MetricsEvent.ACTION_TARGET_SELECTED); log.setComponentName(mRankerServiceName); - log.addTaggedData(MetricsEvent.FIELD_IS_CATEGORY_USED, mAnnotationsUsed); + log.addTaggedData(MetricsEvent.FIELD_IS_CATEGORY_USED, mAnnotationsUsed ? 1 : 0); log.addTaggedData(MetricsEvent.FIELD_RANKED_POSITION, selectedPos); metricsLogger.write(log); }