From ad7d713eda469882de1680667607d0e74186b38b Mon Sep 17 00:00:00 2001 From: Julia Reynolds Date: Wed, 21 Mar 2018 16:05:00 -0400 Subject: [PATCH] Consolidate logic for 'recent notifications' Test: runtest systemui-notification Bug: 74318867 Change-Id: I962fe63f09f466d8e5e8238c66735b20f90c57b4 --- .../server/notification/NotificationManagerService.java | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/services/core/java/com/android/server/notification/NotificationManagerService.java b/services/core/java/com/android/server/notification/NotificationManagerService.java index 27eeb93fa3f5f..59cd561439aa7 100644 --- a/services/core/java/com/android/server/notification/NotificationManagerService.java +++ b/services/core/java/com/android/server/notification/NotificationManagerService.java @@ -1877,13 +1877,13 @@ public class NotificationManagerService extends SystemService { return newSuppressedVisualEffects; } - // TODO: log visual differences, not just audible ones @GuardedBy("mNotificationLock") protected void maybeRecordInterruptionLocked(NotificationRecord r) { if (r.isInterruptive()) { mAppUsageStats.reportInterruptiveNotification(r.sbn.getPackageName(), r.getChannel().getId(), getRealUserId(r.sbn.getUserId())); + logRecentLocked(r); } } @@ -4344,10 +4344,6 @@ public class NotificationManagerService extends SystemService { mNotificationsByKey.put(n.getKey(), r); - if (!r.isUpdate) { - logRecentLocked(r); - } - // Ensure if this is a foreground service that the proper additional // flags are set. if ((notification.flags & Notification.FLAG_FOREGROUND_SERVICE) != 0) {