From d4dd8b8edfdf706121588cd12178956a326d9ea3 Mon Sep 17 00:00:00 2001 From: Greg Kaiser Date: Fri, 25 Oct 2019 12:55:02 -0700 Subject: [PATCH] Declare Visualizer::setEnabled() 'final' We call the virtual method setEnabled() from Visualizer's destructor. In the destructor, the virtual binding is not used. This isn't a problem for any current code, but to future-proof against a possible future subclass of Visualizer, we declare this method 'final'. Test: TreeHugger Change-Id: I703580b37cc1bf7f411caa723f95a691dff840a5 --- media/jni/audioeffect/Visualizer.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/media/jni/audioeffect/Visualizer.h b/media/jni/audioeffect/Visualizer.h index 8078e369ee822..d4672a95c6d88 100644 --- a/media/jni/audioeffect/Visualizer.h +++ b/media/jni/audioeffect/Visualizer.h @@ -73,7 +73,8 @@ public: ~Visualizer(); - virtual status_t setEnabled(bool enabled); + // Declared 'final' because we call this in ~Visualizer(). + status_t setEnabled(bool enabled) final; // maximum capture size in samples static uint32_t getMaxCaptureSize() { return VISUALIZER_CAPTURE_SIZE_MAX; }