Merge changes Ic7751887,I87828825,I223185ac into tm-qpr-dev

* changes:
  Delete PanelViewController
  Remove references to PanelViewController
  Prepare PanelViewController to be absorbed by NPVC
This commit is contained in:
Justin Weir
2022-08-25 22:00:44 +00:00
committed by Android (Google) Code Review
8 changed files with 1394 additions and 1740 deletions

View File

@@ -33,10 +33,10 @@ import com.android.keyguard.KeyguardUpdateMonitor
import com.android.systemui.ActivityIntentHelper import com.android.systemui.ActivityIntentHelper
import com.android.systemui.dagger.qualifiers.Main import com.android.systemui.dagger.qualifiers.Main
import com.android.systemui.plugins.ActivityStarter import com.android.systemui.plugins.ActivityStarter
import com.android.systemui.shade.NotificationPanelViewController
import com.android.systemui.shared.system.ActivityManagerKt.isInForeground import com.android.systemui.shared.system.ActivityManagerKt.isInForeground
import com.android.systemui.statusbar.StatusBarState import com.android.systemui.statusbar.StatusBarState
import com.android.systemui.statusbar.phone.CentralSurfaces import com.android.systemui.statusbar.phone.CentralSurfaces
import com.android.systemui.shade.PanelViewController
import com.android.systemui.statusbar.policy.KeyguardStateController import com.android.systemui.statusbar.policy.KeyguardStateController
import java.util.concurrent.Executor import java.util.concurrent.Executor
import javax.inject.Inject import javax.inject.Inject
@@ -117,7 +117,7 @@ class CameraGestureHelper @Inject constructor(
) )
} catch (e: RemoteException) { } catch (e: RemoteException) {
Log.w( Log.w(
PanelViewController.TAG, NotificationPanelViewController.TAG,
"Unable to start camera activity", "Unable to start camera activity",
e e
) )

View File

@@ -25,7 +25,7 @@ import com.android.systemui.R;
import com.android.systemui.dagger.qualifiers.Main; import com.android.systemui.dagger.qualifiers.Main;
import com.android.systemui.dreams.touch.BouncerSwipeTouchHandler; import com.android.systemui.dreams.touch.BouncerSwipeTouchHandler;
import com.android.systemui.dreams.touch.DreamTouchHandler; import com.android.systemui.dreams.touch.DreamTouchHandler;
import com.android.systemui.shade.PanelViewController; import com.android.systemui.shade.NotificationPanelViewController;
import com.android.wm.shell.animation.FlingAnimationUtils; import com.android.wm.shell.animation.FlingAnimationUtils;
import javax.inject.Named; import javax.inject.Named;
@@ -77,8 +77,9 @@ public class BouncerSwipeModule {
Provider<FlingAnimationUtils.Builder> flingAnimationUtilsBuilderProvider) { Provider<FlingAnimationUtils.Builder> flingAnimationUtilsBuilderProvider) {
return flingAnimationUtilsBuilderProvider.get() return flingAnimationUtilsBuilderProvider.get()
.reset() .reset()
.setMaxLengthSeconds(PanelViewController.FLING_CLOSING_MAX_LENGTH_SECONDS) .setMaxLengthSeconds(
.setSpeedUpFactor(PanelViewController.FLING_SPEED_UP_FACTOR) NotificationPanelViewController.FLING_CLOSING_MAX_LENGTH_SECONDS)
.setSpeedUpFactor(NotificationPanelViewController.FLING_SPEED_UP_FACTOR)
.build(); .build();
} }
@@ -91,8 +92,8 @@ public class BouncerSwipeModule {
Provider<FlingAnimationUtils.Builder> flingAnimationUtilsBuilderProvider) { Provider<FlingAnimationUtils.Builder> flingAnimationUtilsBuilderProvider) {
return flingAnimationUtilsBuilderProvider.get() return flingAnimationUtilsBuilderProvider.get()
.reset() .reset()
.setMaxLengthSeconds(PanelViewController.FLING_MAX_LENGTH_SECONDS) .setMaxLengthSeconds(NotificationPanelViewController.FLING_MAX_LENGTH_SECONDS)
.setSpeedUpFactor(PanelViewController.FLING_SPEED_UP_FACTOR) .setSpeedUpFactor(NotificationPanelViewController.FLING_SPEED_UP_FACTOR)
.build(); .build();
} }

View File

@@ -29,7 +29,7 @@ import com.android.systemui.statusbar.phone.KeyguardBottomAreaView;
public abstract class PanelView extends FrameLayout { public abstract class PanelView extends FrameLayout {
public static final boolean DEBUG = false; public static final boolean DEBUG = false;
public static final String TAG = PanelView.class.getSimpleName(); public static final String TAG = PanelView.class.getSimpleName();
private PanelViewController.TouchHandler mTouchHandler; private NotificationPanelViewController.TouchHandler mTouchHandler;
protected CentralSurfaces mCentralSurfaces; protected CentralSurfaces mCentralSurfaces;
protected HeadsUpManagerPhone mHeadsUpManager; protected HeadsUpManagerPhone mHeadsUpManager;
@@ -49,7 +49,7 @@ public abstract class PanelView extends FrameLayout {
super(context, attrs, defStyleAttr); super(context, attrs, defStyleAttr);
} }
public void setOnTouchListener(PanelViewController.TouchHandler touchHandler) { public void setOnTouchListener(NotificationPanelViewController.TouchHandler touchHandler) {
super.setOnTouchListener(touchHandler); super.setOnTouchListener(touchHandler);
mTouchHandler = touchHandler; mTouchHandler = touchHandler;
} }

View File

@@ -259,7 +259,7 @@ public class NotificationPanelViewControllerTest extends SysuiTestCase {
private DisplayMetrics mDisplayMetrics = new DisplayMetrics(); private DisplayMetrics mDisplayMetrics = new DisplayMetrics();
@Mock @Mock
private KeyguardClockSwitch mKeyguardClockSwitch; private KeyguardClockSwitch mKeyguardClockSwitch;
private PanelViewController.TouchHandler mTouchHandler; private NotificationPanelViewController.TouchHandler mTouchHandler;
private ConfigurationController mConfigurationController; private ConfigurationController mConfigurationController;
@Mock @Mock
private MediaHierarchyManager mMediaHiearchyManager; private MediaHierarchyManager mMediaHiearchyManager;
@@ -454,7 +454,7 @@ public class NotificationPanelViewControllerTest extends SysuiTestCase {
doAnswer((Answer<Void>) invocation -> { doAnswer((Answer<Void>) invocation -> {
mTouchHandler = invocation.getArgument(0); mTouchHandler = invocation.getArgument(0);
return null; return null;
}).when(mView).setOnTouchListener(any(PanelViewController.TouchHandler.class)); }).when(mView).setOnTouchListener(any(NotificationPanelViewController.TouchHandler.class));
NotificationWakeUpCoordinator coordinator = NotificationWakeUpCoordinator coordinator =
new NotificationWakeUpCoordinator( new NotificationWakeUpCoordinator(
@@ -1407,7 +1407,7 @@ public class NotificationPanelViewControllerTest extends SysuiTestCase {
when(mQsFrame.getWidth()).thenReturn(1000); when(mQsFrame.getWidth()).thenReturn(1000);
when(mQsHeader.getTop()).thenReturn(0); when(mQsHeader.getTop()).thenReturn(0);
when(mQsHeader.getBottom()).thenReturn(1000); when(mQsHeader.getBottom()).thenReturn(1000);
PanelViewController.TouchHandler touchHandler = NotificationPanelViewController.TouchHandler touchHandler =
mNotificationPanelViewController.createTouchHandler(); mNotificationPanelViewController.createTouchHandler();
mNotificationPanelViewController.setExpandedFraction(1f); mNotificationPanelViewController.setExpandedFraction(1f);
@@ -1427,7 +1427,7 @@ public class NotificationPanelViewControllerTest extends SysuiTestCase {
when(mQsFrame.getWidth()).thenReturn(1000); when(mQsFrame.getWidth()).thenReturn(1000);
when(mQsHeader.getTop()).thenReturn(0); when(mQsHeader.getTop()).thenReturn(0);
when(mQsHeader.getBottom()).thenReturn(1000); when(mQsHeader.getBottom()).thenReturn(1000);
PanelViewController.TouchHandler touchHandler = NotificationPanelViewController.TouchHandler touchHandler =
mNotificationPanelViewController.createTouchHandler(); mNotificationPanelViewController.createTouchHandler();
mNotificationPanelViewController.setExpandedFraction(1f); mNotificationPanelViewController.setExpandedFraction(1f);

View File

@@ -26,22 +26,22 @@ import androidx.test.filters.SmallTest
import androidx.test.platform.app.InstrumentationRegistry import androidx.test.platform.app.InstrumentationRegistry
import com.android.systemui.R import com.android.systemui.R
import com.android.systemui.SysuiTestCase import com.android.systemui.SysuiTestCase
import com.android.systemui.shade.PanelViewController import com.android.systemui.shade.NotificationPanelViewController
import com.android.systemui.statusbar.phone.userswitcher.StatusBarUserSwitcherController import com.android.systemui.statusbar.phone.userswitcher.StatusBarUserSwitcherController
import com.android.systemui.statusbar.policy.ConfigurationController import com.android.systemui.statusbar.policy.ConfigurationController
import com.android.systemui.unfold.SysUIUnfoldComponent import com.android.systemui.unfold.SysUIUnfoldComponent
import com.android.systemui.unfold.config.UnfoldTransitionConfig import com.android.systemui.unfold.config.UnfoldTransitionConfig
import com.android.systemui.unfold.util.ScopedUnfoldTransitionProgressProvider import com.android.systemui.unfold.util.ScopedUnfoldTransitionProgressProvider
import com.android.systemui.util.view.ViewUtil
import com.android.systemui.util.mockito.any import com.android.systemui.util.mockito.any
import com.android.systemui.util.view.ViewUtil
import com.google.common.truth.Truth.assertThat import com.google.common.truth.Truth.assertThat
import org.junit.Before import org.junit.Before
import org.junit.Test import org.junit.Test
import org.mockito.ArgumentCaptor import org.mockito.ArgumentCaptor
import org.mockito.Mock import org.mockito.Mock
import org.mockito.Mockito.spy
import org.mockito.Mockito.mock
import org.mockito.Mockito.`when` import org.mockito.Mockito.`when`
import org.mockito.Mockito.mock
import org.mockito.Mockito.spy
import org.mockito.Mockito.verify import org.mockito.Mockito.verify
import org.mockito.MockitoAnnotations import org.mockito.MockitoAnnotations
import java.util.Optional import java.util.Optional
@@ -52,7 +52,7 @@ class PhoneStatusBarViewControllerTest : SysuiTestCase() {
private val touchEventHandler = TestTouchEventHandler() private val touchEventHandler = TestTouchEventHandler()
@Mock @Mock
private lateinit var panelViewController: PanelViewController private lateinit var notificationPanelViewController: NotificationPanelViewController
@Mock @Mock
private lateinit var panelView: ViewGroup private lateinit var panelView: ViewGroup
@Mock @Mock
@@ -76,7 +76,7 @@ class PhoneStatusBarViewControllerTest : SysuiTestCase() {
@Before @Before
fun setUp() { fun setUp() {
MockitoAnnotations.initMocks(this) MockitoAnnotations.initMocks(this)
`when`(panelViewController.view).thenReturn(panelView) `when`(notificationPanelViewController.view).thenReturn(panelView)
`when`(sysuiUnfoldComponent.getStatusBarMoveFromCenterAnimationController()) `when`(sysuiUnfoldComponent.getStatusBarMoveFromCenterAnimationController())
.thenReturn(moveFromCenterAnimation) .thenReturn(moveFromCenterAnimation)
// create the view on main thread as it requires main looper // create the view on main thread as it requires main looper

View File

@@ -20,7 +20,7 @@ import android.view.MotionEvent
import android.view.ViewGroup import android.view.ViewGroup
import androidx.test.filters.SmallTest import androidx.test.filters.SmallTest
import com.android.systemui.SysuiTestCase import com.android.systemui.SysuiTestCase
import com.android.systemui.shade.PanelViewController import com.android.systemui.shade.NotificationPanelViewController
import com.google.common.truth.Truth.assertThat import com.google.common.truth.Truth.assertThat
import org.junit.Before import org.junit.Before
import org.junit.Test import org.junit.Test
@@ -32,7 +32,7 @@ import org.mockito.MockitoAnnotations
class PhoneStatusBarViewTest : SysuiTestCase() { class PhoneStatusBarViewTest : SysuiTestCase() {
@Mock @Mock
private lateinit var panelViewController: PanelViewController private lateinit var notificationPanelViewController: NotificationPanelViewController
@Mock @Mock
private lateinit var panelView: ViewGroup private lateinit var panelView: ViewGroup
@@ -43,7 +43,7 @@ class PhoneStatusBarViewTest : SysuiTestCase() {
MockitoAnnotations.initMocks(this) MockitoAnnotations.initMocks(this)
// TODO(b/197137564): Setting up a panel view and its controller feels unnecessary when // TODO(b/197137564): Setting up a panel view and its controller feels unnecessary when
// testing just [PhoneStatusBarView]. // testing just [PhoneStatusBarView].
`when`(panelViewController.view).thenReturn(panelView) `when`(notificationPanelViewController.view).thenReturn(panelView)
view = PhoneStatusBarView(mContext, null) view = PhoneStatusBarView(mContext, null)
} }