diff --git a/services/core/java/com/android/server/biometrics/sensors/InternalCleanupClient.java b/services/core/java/com/android/server/biometrics/sensors/InternalCleanupClient.java index 5c08bce9b44f0..e738d17f5f17d 100644 --- a/services/core/java/com/android/server/biometrics/sensors/InternalCleanupClient.java +++ b/services/core/java/com/android/server/biometrics/sensors/InternalCleanupClient.java @@ -57,7 +57,7 @@ public abstract class InternalCleanupClient mUnknownHALTemplates = new ArrayList<>(); - private final BiometricUtils mBiometricUtils; + private final BiometricUtils mBiometricUtils; private final Map mAuthenticatorIds; private final List mEnrolledList; private ClientMonitor mCurrentTask; @@ -95,15 +95,15 @@ public abstract class InternalCleanupClient getEnumerateClient(Context context, LazyDaemon lazyDaemon, IBinder token, int userId, String owner, - List enrolledList, BiometricUtils utils, int sensorId); + List enrolledList, BiometricUtils utils, int sensorId); - protected abstract RemovalClient getRemovalClient(Context context, LazyDaemon lazyDaemon, - IBinder token, int biometricId, int userId, String owner, BiometricUtils utils, - int sensorId, Map authenticatorIds); + protected abstract RemovalClient getRemovalClient(Context context, + LazyDaemon lazyDaemon, IBinder token, int biometricId, int userId, String owner, + BiometricUtils utils, int sensorId, Map authenticatorIds); protected InternalCleanupClient(@NonNull Context context, @NonNull LazyDaemon lazyDaemon, int userId, @NonNull String owner, int sensorId, int statsModality, - @NonNull List enrolledList, @NonNull BiometricUtils utils, + @NonNull List enrolledList, @NonNull BiometricUtils utils, @NonNull Map authenticatorIds) { super(context, lazyDaemon, null /* token */, null /* ClientMonitorCallbackConverter */, userId, owner, 0 /* cookie */, sensorId, statsModality, @@ -153,7 +153,7 @@ public abstract class InternalCleanupClient) mCurrentTask).onRemoved(identifier, remaining); + ((RemovalClient) mCurrentTask).onRemoved(identifier, remaining); } @Override diff --git a/services/core/java/com/android/server/biometrics/sensors/RemovalClient.java b/services/core/java/com/android/server/biometrics/sensors/RemovalClient.java index 1348f797a2dc7..ce898fa3b2bfd 100644 --- a/services/core/java/com/android/server/biometrics/sensors/RemovalClient.java +++ b/services/core/java/com/android/server/biometrics/sensors/RemovalClient.java @@ -29,17 +29,18 @@ import java.util.Map; /** * A class to keep track of the remove state for a given client. */ -public abstract class RemovalClient extends ClientMonitor implements RemovalConsumer { +public abstract class RemovalClient + extends ClientMonitor implements RemovalConsumer { private static final String TAG = "Biometrics/RemovalClient"; protected final int mBiometricId; - private final BiometricUtils mBiometricUtils; + private final BiometricUtils mBiometricUtils; private final Map mAuthenticatorIds; public RemovalClient(@NonNull Context context, @NonNull LazyDaemon lazyDaemon, @NonNull IBinder token, @NonNull ClientMonitorCallbackConverter listener, - int biometricId, int userId, @NonNull String owner, @NonNull BiometricUtils utils, + int biometricId, int userId, @NonNull String owner, @NonNull BiometricUtils utils, int sensorId, @NonNull Map authenticatorIds, int statsModality) { super(context, lazyDaemon, token, listener, userId, owner, 0 /* cookie */, sensorId, statsModality, BiometricsProtoEnums.ACTION_REMOVE, diff --git a/services/core/java/com/android/server/biometrics/sensors/face/FaceEnrollClient.java b/services/core/java/com/android/server/biometrics/sensors/face/FaceEnrollClient.java index 3e843cae96fd5..989b5c938cbc6 100644 --- a/services/core/java/com/android/server/biometrics/sensors/face/FaceEnrollClient.java +++ b/services/core/java/com/android/server/biometrics/sensors/face/FaceEnrollClient.java @@ -23,6 +23,7 @@ import android.hardware.biometrics.BiometricFaceConstants; import android.hardware.biometrics.BiometricsProtoEnums; import android.hardware.biometrics.face.V1_0.IBiometricsFace; import android.hardware.biometrics.face.V1_0.Status; +import android.hardware.face.Face; import android.hardware.face.FaceManager; import android.os.IBinder; import android.os.NativeHandle; @@ -53,9 +54,9 @@ public class FaceEnrollClient extends EnrollClient { FaceEnrollClient(@NonNull Context context, @NonNull LazyDaemon lazyDaemon, @NonNull IBinder token, @NonNull ClientMonitorCallbackConverter listener, int userId, - @NonNull byte[] hardwareAuthToken, @NonNull String owner, @NonNull BiometricUtils utils, - @NonNull int[] disabledFeatures, int timeoutSec, @Nullable NativeHandle surfaceHandle, - int sensorId) { + @NonNull byte[] hardwareAuthToken, @NonNull String owner, + @NonNull BiometricUtils utils, @NonNull int[] disabledFeatures, int timeoutSec, + @Nullable NativeHandle surfaceHandle, int sensorId) { super(context, lazyDaemon, token, listener, userId, hardwareAuthToken, owner, utils, timeoutSec, BiometricsProtoEnums.MODALITY_FACE, sensorId, false /* shouldVibrate */); diff --git a/services/core/java/com/android/server/biometrics/sensors/face/FaceInternalCleanupClient.java b/services/core/java/com/android/server/biometrics/sensors/face/FaceInternalCleanupClient.java index 93f35f4c90cdd..7626587f5519c 100644 --- a/services/core/java/com/android/server/biometrics/sensors/face/FaceInternalCleanupClient.java +++ b/services/core/java/com/android/server/biometrics/sensors/face/FaceInternalCleanupClient.java @@ -40,7 +40,7 @@ class FaceInternalCleanupClient extends InternalCleanupClient lazyDaemon, int userId, @NonNull String owner, - int sensorId, @NonNull List enrolledList, @NonNull BiometricUtils utils, + int sensorId, @NonNull List enrolledList, @NonNull BiometricUtils utils, @NonNull Map authenticatorIds) { super(context, lazyDaemon, userId, owner, sensorId, BiometricsProtoEnums.MODALITY_FACE, enrolledList, utils, authenticatorIds); @@ -49,15 +49,15 @@ class FaceInternalCleanupClient extends InternalCleanupClient getEnumerateClient(Context context, LazyDaemon lazyDaemon, IBinder token, int userId, String owner, - List enrolledList, BiometricUtils utils, int sensorId) { + List enrolledList, BiometricUtils utils, int sensorId) { return new FaceInternalEnumerateClient(context, lazyDaemon, token, userId, owner, enrolledList, utils, sensorId); } @Override - protected RemovalClient getRemovalClient(Context context, + protected RemovalClient getRemovalClient(Context context, LazyDaemon lazyDaemon, IBinder token, - int biometricId, int userId, String owner, BiometricUtils utils, int sensorId, + int biometricId, int userId, String owner, BiometricUtils utils, int sensorId, Map authenticatorIds) { // Internal remove does not need to send results to anyone. Cleanup (enumerate + remove) // is all done internally. diff --git a/services/core/java/com/android/server/biometrics/sensors/face/FaceInternalEnumerateClient.java b/services/core/java/com/android/server/biometrics/sensors/face/FaceInternalEnumerateClient.java index 32d48321428ae..4166dff853320 100644 --- a/services/core/java/com/android/server/biometrics/sensors/face/FaceInternalEnumerateClient.java +++ b/services/core/java/com/android/server/biometrics/sensors/face/FaceInternalEnumerateClient.java @@ -40,8 +40,8 @@ class FaceInternalEnumerateClient extends InternalEnumerateClient lazyDaemon, @NonNull IBinder token, int userId, - @NonNull String owner, @NonNull List enrolledList, @NonNull BiometricUtils utils, - int sensorId) { + @NonNull String owner, @NonNull List enrolledList, + @NonNull BiometricUtils utils, int sensorId) { super(context, lazyDaemon, token, userId, owner, enrolledList, utils, sensorId, BiometricsProtoEnums.MODALITY_FACE); } diff --git a/services/core/java/com/android/server/biometrics/sensors/face/FaceRemovalClient.java b/services/core/java/com/android/server/biometrics/sensors/face/FaceRemovalClient.java index dde5ababd6c0d..31ae3a387f909 100644 --- a/services/core/java/com/android/server/biometrics/sensors/face/FaceRemovalClient.java +++ b/services/core/java/com/android/server/biometrics/sensors/face/FaceRemovalClient.java @@ -20,6 +20,7 @@ import android.annotation.NonNull; import android.content.Context; import android.hardware.biometrics.BiometricsProtoEnums; import android.hardware.biometrics.face.V1_0.IBiometricsFace; +import android.hardware.face.Face; import android.os.IBinder; import android.os.RemoteException; import android.util.Slog; @@ -34,12 +35,12 @@ import java.util.Map; * Face-specific removal client supporting the {@link android.hardware.biometrics.face.V1_0} * and {@link android.hardware.biometrics.face.V1_1} HIDL interfaces. */ -class FaceRemovalClient extends RemovalClient { +class FaceRemovalClient extends RemovalClient { private static final String TAG = "FaceRemovalClient"; FaceRemovalClient(@NonNull Context context, @NonNull LazyDaemon lazyDaemon, @NonNull IBinder token, @NonNull ClientMonitorCallbackConverter listener, - int biometricId, int userId, @NonNull String owner, @NonNull BiometricUtils utils, + int biometricId, int userId, @NonNull String owner, @NonNull BiometricUtils utils, int sensorId, @NonNull Map authenticatorIds) { super(context, lazyDaemon, token, listener, biometricId, userId, owner, utils, sensorId, authenticatorIds, BiometricsProtoEnums.MODALITY_FACE); diff --git a/services/core/java/com/android/server/biometrics/sensors/fingerprint/aidl/FingerprintEnrollClient.java b/services/core/java/com/android/server/biometrics/sensors/fingerprint/aidl/FingerprintEnrollClient.java index 7a7ad6493c382..062fbbd3b73eb 100644 --- a/services/core/java/com/android/server/biometrics/sensors/fingerprint/aidl/FingerprintEnrollClient.java +++ b/services/core/java/com/android/server/biometrics/sensors/fingerprint/aidl/FingerprintEnrollClient.java @@ -24,8 +24,8 @@ import android.hardware.biometrics.BiometricFingerprintConstants; import android.hardware.biometrics.BiometricsProtoEnums; import android.hardware.biometrics.common.ICancellationSignal; import android.hardware.biometrics.fingerprint.ISession; +import android.hardware.fingerprint.Fingerprint; import android.hardware.fingerprint.IUdfpsOverlayController; -import android.hardware.keymaster.HardwareAuthToken; import android.os.IBinder; import android.os.RemoteException; import android.util.Slog; @@ -50,7 +50,7 @@ public class FingerprintEnrollClient extends EnrollClient implements U @NonNull LazyDaemon lazyDaemon, @NonNull IBinder token, @NonNull ClientMonitorCallbackConverter listener, int userId, @NonNull byte[] hardwareAuthToken, @NonNull String owner, - @NonNull FingerprintUtils utils, int sensorId, + @NonNull BiometricUtils utils, int sensorId, @Nullable IUdfpsOverlayController udfpsOvelayController, int maxTemplatesPerUser) { super(context, lazyDaemon, token, listener, userId, hardwareAuthToken, owner, utils, 0 /* timeoutSec */, BiometricsProtoEnums.MODALITY_FINGERPRINT, sensorId, diff --git a/services/core/java/com/android/server/biometrics/sensors/fingerprint/aidl/FingerprintRemovalClient.java b/services/core/java/com/android/server/biometrics/sensors/fingerprint/aidl/FingerprintRemovalClient.java index df063dc34017d..d567bbc0edceb 100644 --- a/services/core/java/com/android/server/biometrics/sensors/fingerprint/aidl/FingerprintRemovalClient.java +++ b/services/core/java/com/android/server/biometrics/sensors/fingerprint/aidl/FingerprintRemovalClient.java @@ -20,13 +20,14 @@ import android.annotation.NonNull; import android.content.Context; import android.hardware.biometrics.BiometricsProtoEnums; import android.hardware.biometrics.fingerprint.ISession; +import android.hardware.fingerprint.Fingerprint; import android.os.IBinder; import android.os.RemoteException; import android.util.Slog; +import com.android.server.biometrics.sensors.BiometricUtils; import com.android.server.biometrics.sensors.ClientMonitorCallbackConverter; import com.android.server.biometrics.sensors.RemovalClient; -import com.android.server.biometrics.sensors.fingerprint.FingerprintUtils; import java.util.Map; @@ -34,13 +35,13 @@ import java.util.Map; * Fingerprint-specific removal client supporting the * {@link android.hardware.biometrics.fingerprint.IFingerprint} interface. */ -public class FingerprintRemovalClient extends RemovalClient { +public class FingerprintRemovalClient extends RemovalClient { private static final String TAG = "FingerprintRemovalClient"; public FingerprintRemovalClient(@NonNull Context context, @NonNull LazyDaemon lazyDaemon, @NonNull IBinder token, @NonNull ClientMonitorCallbackConverter listener, int biometricId, int userId, - @NonNull String owner, @NonNull FingerprintUtils utils, int sensorId, + @NonNull String owner, @NonNull BiometricUtils utils, int sensorId, @NonNull Map authenticatorIds) { super(context, lazyDaemon, token, listener, biometricId, userId, owner, utils, sensorId, authenticatorIds, BiometricsProtoEnums.MODALITY_FINGERPRINT); diff --git a/services/core/java/com/android/server/biometrics/sensors/fingerprint/hidl/FingerprintEnrollClient.java b/services/core/java/com/android/server/biometrics/sensors/fingerprint/hidl/FingerprintEnrollClient.java index 975ac3d6f2bfe..c750b906c9b60 100644 --- a/services/core/java/com/android/server/biometrics/sensors/fingerprint/hidl/FingerprintEnrollClient.java +++ b/services/core/java/com/android/server/biometrics/sensors/fingerprint/hidl/FingerprintEnrollClient.java @@ -22,6 +22,7 @@ import android.content.Context; import android.hardware.biometrics.BiometricFingerprintConstants; import android.hardware.biometrics.BiometricsProtoEnums; import android.hardware.biometrics.fingerprint.V2_1.IBiometricsFingerprint; +import android.hardware.fingerprint.Fingerprint; import android.hardware.fingerprint.IUdfpsOverlayController; import android.os.IBinder; import android.os.RemoteException; @@ -48,8 +49,8 @@ public class FingerprintEnrollClient extends EnrollClient lazyDaemon, @NonNull IBinder token, @NonNull ClientMonitorCallbackConverter listener, int userId, - @NonNull byte[] hardwareAuthToken, @NonNull String owner, @NonNull BiometricUtils utils, - int timeoutSec, int sensorId, + @NonNull byte[] hardwareAuthToken, @NonNull String owner, + @NonNull BiometricUtils utils, int timeoutSec, int sensorId, @Nullable IUdfpsOverlayController udfpsOverlayController) { super(context, lazyDaemon, token, listener, userId, hardwareAuthToken, owner, utils, timeoutSec, BiometricsProtoEnums.MODALITY_FINGERPRINT, sensorId, diff --git a/services/core/java/com/android/server/biometrics/sensors/fingerprint/hidl/FingerprintInternalCleanupClient.java b/services/core/java/com/android/server/biometrics/sensors/fingerprint/hidl/FingerprintInternalCleanupClient.java index e0611120c69ab..a42a8ae24926d 100644 --- a/services/core/java/com/android/server/biometrics/sensors/fingerprint/hidl/FingerprintInternalCleanupClient.java +++ b/services/core/java/com/android/server/biometrics/sensors/fingerprint/hidl/FingerprintInternalCleanupClient.java @@ -42,7 +42,8 @@ class FingerprintInternalCleanupClient FingerprintInternalCleanupClient(@NonNull Context context, @NonNull LazyDaemon lazyDaemon, int userId, @NonNull String owner, int sensorId, @NonNull List enrolledList, - @NonNull BiometricUtils utils, @NonNull Map authenticatorIds) { + @NonNull BiometricUtils utils, + @NonNull Map authenticatorIds) { super(context, lazyDaemon, userId, owner, sensorId, BiometricsProtoEnums.MODALITY_FINGERPRINT, enrolledList, utils, authenticatorIds); } @@ -50,18 +51,17 @@ class FingerprintInternalCleanupClient @Override protected InternalEnumerateClient getEnumerateClient( Context context, LazyDaemon lazyDaemon, IBinder token, - int userId, String owner, - List enrolledList, BiometricUtils utils, - int sensorId) { + int userId, String owner, List enrolledList, + BiometricUtils utils, int sensorId) { return new FingerprintInternalEnumerateClient(context, lazyDaemon, token, userId, owner, enrolledList, utils, sensorId); } @Override - protected RemovalClient getRemovalClient(Context context, + protected RemovalClient getRemovalClient(Context context, LazyDaemon lazyDaemon, IBinder token, - int biometricId, int userId, String owner, BiometricUtils utils, int sensorId, - Map authenticatorIds) { + int biometricId, int userId, String owner, BiometricUtils utils, + int sensorId, Map authenticatorIds) { // Internal remove does not need to send results to anyone. Cleanup (enumerate + remove) // is all done internally. return new FingerprintRemovalClient(context, lazyDaemon, token, diff --git a/services/core/java/com/android/server/biometrics/sensors/fingerprint/hidl/FingerprintInternalEnumerateClient.java b/services/core/java/com/android/server/biometrics/sensors/fingerprint/hidl/FingerprintInternalEnumerateClient.java index 5fd1d1e812ce8..7117cf382a60b 100644 --- a/services/core/java/com/android/server/biometrics/sensors/fingerprint/hidl/FingerprintInternalEnumerateClient.java +++ b/services/core/java/com/android/server/biometrics/sensors/fingerprint/hidl/FingerprintInternalEnumerateClient.java @@ -41,7 +41,7 @@ class FingerprintInternalEnumerateClient extends InternalEnumerateClient lazyDaemon, @NonNull IBinder token, int userId, @NonNull String owner, @NonNull List enrolledList, - @NonNull BiometricUtils utils, int sensorId) { + @NonNull BiometricUtils utils, int sensorId) { super(context, lazyDaemon, token, userId, owner, enrolledList, utils, sensorId, BiometricsProtoEnums.MODALITY_FINGERPRINT); } diff --git a/services/core/java/com/android/server/biometrics/sensors/fingerprint/hidl/FingerprintRemovalClient.java b/services/core/java/com/android/server/biometrics/sensors/fingerprint/hidl/FingerprintRemovalClient.java index 4bbb7efa21660..f6a22f581f1a7 100644 --- a/services/core/java/com/android/server/biometrics/sensors/fingerprint/hidl/FingerprintRemovalClient.java +++ b/services/core/java/com/android/server/biometrics/sensors/fingerprint/hidl/FingerprintRemovalClient.java @@ -20,6 +20,7 @@ import android.annotation.NonNull; import android.content.Context; import android.hardware.biometrics.BiometricsProtoEnums; import android.hardware.biometrics.fingerprint.V2_1.IBiometricsFingerprint; +import android.hardware.fingerprint.Fingerprint; import android.os.IBinder; import android.os.RemoteException; import android.util.Slog; @@ -35,13 +36,13 @@ import java.util.Map; * {@link android.hardware.biometrics.fingerprint.V2_1} and * {@link android.hardware.biometrics.fingerprint.V2_2} HIDL interfaces. */ -class FingerprintRemovalClient extends RemovalClient { +class FingerprintRemovalClient extends RemovalClient { private static final String TAG = "FingerprintRemovalClient"; FingerprintRemovalClient(@NonNull Context context, @NonNull LazyDaemon lazyDaemon, @NonNull IBinder token, @NonNull ClientMonitorCallbackConverter listener, int biometricId, int userId, - @NonNull String owner, @NonNull BiometricUtils utils, int sensorId, + @NonNull String owner, @NonNull BiometricUtils utils, int sensorId, @NonNull Map authenticatorIds) { super(context, lazyDaemon, token, listener, biometricId, userId, owner, utils, sensorId, authenticatorIds, BiometricsProtoEnums.MODALITY_FINGERPRINT);